Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nfc][llvm-profdata] Use cl::Subcommand to organize subcommand and options in llvm-profdata #71328

Merged
merged 8 commits into from
Nov 14, 2023
Merged

[nfc][llvm-profdata] Use cl::Subcommand to organize subcommand and options in llvm-profdata #71328

merged 8 commits into from
Nov 14, 2023

Commits on Nov 7, 2023

  1. [nfc][llvm-profdata] Move show options to its namespace

    @minglotus-6
    minglotus-6 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    e9b590a View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Add show_options namespace and move show_options from function scope to 

    namespace.
- The change uses cl::SubCommand feature that allow to register options
  under a subcommand.
  - Without using cl::SubCommand, the options in the show name namespace will
    take a registered name as global variables, causing runtime errors when a
    function-scope static option tries to add a function of a same name.
  - Make changes in the CommandLine library accordingly.
    @minglotus-6
    minglotus-6 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    02a0de6 View commit details
    Browse the repository at this point in the history

  2. resolve feedback

    @minglotus-6
    minglotus-6 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c9bdcf9 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Refactor llvm-profdata to use cl::subcommand

    @minglotus-6
    minglotus-6 committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    770e167 View commit details
    Browse the repository at this point in the history

  2. undo one-line added during debugging

    @minglotus-6
    minglotus-6 committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    6fc1bfa View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'main' into llvm-profdata

    @minglotus-6
    minglotus-6 committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    d71edf1 View commit details
    Browse the repository at this point in the history

  2. resolve feedback

    @minglotus-6
    minglotus-6 committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    0f3951d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. move enum definition before option definition

    @minglotus-6
    minglotus-6 committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5b9e7dc View commit details
    Browse the repository at this point in the history