Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-automation: Use the llvm/llvm-project repo for backport pull requests #71727

Merged
merged 2 commits into from Jan 12, 2024

Conversation

tstellar
Copy link
Collaborator

@tstellar tstellar commented Nov 8, 2023

Now that the project uses PRs for code review, we don't need to use the llvm/llvm-project-release-prs repo for reviewing backports.

…equests

Now that the project uses PRs for code review, we don't need to use the
llvm/llvm-project-release-prs repo for reviewing backports.
@tstellar tstellar requested a review from tru November 8, 2023 19:20
Copy link

github-actions bot commented Nov 8, 2023

✅ With the latest revision this PR passed the Python code formatter.

@tru
Copy link
Collaborator

tru commented Nov 9, 2023

Do we want to merge this now? or just wait until 17.x is done? otherwise I'll have PRs in two different repos that I need to check.

@tstellar
Copy link
Collaborator Author

tstellar commented Nov 9, 2023

@tru We should wait until 17.x is done to merge this.

@tstellar
Copy link
Collaborator Author

@tru This is ready for review/merge now.

@tru
Copy link
Collaborator

tru commented Nov 29, 2023

@tru This is ready for review/merge now.

Hmm. Yeah - I wonder if we should allow for a little more time to make sure we don't want to do an emergency 17.x release. I guess we still could but we would have to ad-hoc the cherry-picking in that case. I guess I am fine with that as well, we just need to keep that in mind.

@tstellar
Copy link
Collaborator Author

Ok, it's fine with me too if we want to wait a little longer.

@tstellar
Copy link
Collaborator Author

@tru Ping on this one.

Copy link
Collaborator

@tru tru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tstellar tstellar merged commit f33e927 into llvm:main Jan 12, 2024
3 checks passed
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this pull request Jan 28, 2024
…equests (llvm#71727)

Now that the project uses PRs for code review, we don't need to use the
llvm/llvm-project-release-prs repo for reviewing backports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants