Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flang][OpenMP] Initial mapping of Fortran pointers and allocatables for target devices #71766
[Flang][OpenMP] Initial mapping of Fortran pointers and allocatables for target devices #71766
Changes from all commits
be14124
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this function might not see much use outside of the code added in this PR. Perhaps, we should have it as a local function/lambda instead?
If you feel like this is useful to have standalone, then we can keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used in a few different files in this case and I believe I was asked to make a utility function for this check earlier in this review, so I'd prefer to keep it as a utility function for the time being! Likely quite helpful if what classifies a descriptor type in Flang ever changes as well and it hopefully helps to make it clear what a descriptor type is represented as for newer implementors.