Reland "[Pass][CodeGen] Add some necessary passes for codegen" #71783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bulbazord not sure if this version fixes the build failure issue, at least, I can build |
paperchalice
force-pushed
the
NPM/CodeGen/pass
branch
from
bf67db7
to
b6a42e8
Compare
arsenm
approved these changes
Nov 9, 2023
paperchalice
force-pushed
the
NPM/CodeGen/pass
branch
from
b6a42e8
to
3c76bcc
Compare
|
Rebased, and notice that there are two different prolog/epilog passes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, there are two
KCFIpasses in source tree,CodeGen/KCFI.cppandTransforms/Instrumentation/KCFI.cpp, useMachineKCFIPassfor machine function pass.MIRProfileLoaderPassis resolved to the legacy one whenLLVM_ENABLE_MODULES=ON, useMIRProfileLoaderNewPassas a workaround.