[CFIInstrInserter] Use number of supported registers (NFC) #71797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes use of the more accurate register number introduced in PR llvm#70222 to avoid CFI calculations for unsupported registers.
KanRobert
reviewed
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the more accurate register number introduced in PR #70222 to avoid CFI calculations for unsupported registers.
This has basically no impact right now, but results in the following compile-time improvement when applied on top of #70958: http://llvm-compile-time-tracker.com/compare.php?from=0310d2a00e16d94db50cd811a4013d9f0d4f3317&to=67978ffd8bae44581f23dc7bde6fbf8ab1662d18&stat=instructions:u
The reason is that the extra registers that PR adds push the
BitVectorout of theSmallVectorspace, which results in an outsized impact. (This does make me wonder whetherBitVectorshould accept anNtemplate parameter to allow using a largerSmallVector...)