[BOLT] Fix LSDA section handling #71821
Conversation
|
Genle ping |
There was a problem hiding this comment.
Code looks good but I would drop the test case, because it makes us depend on a compiler that generates a section named .gcc_except_table.main. If you really want to check that a binary has a specific section name, and you are using a linker script, just create the section with that name in your linker script:
.gcc_except_table.main : { *(.gcc_except_table*) }
|
@rafaelauler Thanks! But that is why I've checked that the initial binary has this section, if this behaviour would be changed in clang somebody would have to fix it before submitting this :) From time to time we have the tests that rely on the compiler behaviour, maybe more than needed.. But I don't see a reason not to add the string to the link script, so I would do it. Thanks again! |
Currently BOLT finds LSDA secition by it's name .gcc_except_table.main . But sometimes it might have suffix e.g. .gcc_except_table.main. Find LSDA section by it's address, rather by it's name. Fixes llvm#71804
| // RUN: %clang++ %cxxflags -O3 -flto=thin -no-pie -c %s -o %t.o | ||
| // RUN: %clang++ %cxxflags -flto=thin -no-pie -fuse-ld=lld %t.o -o %t.exe \ |
There was a problem hiding this comment.
Is ThinLTO flag needed for this test case?
There was a problem hiding this comment.
Currently definitely not since I've added @rafaelauler offer to the ld script at least (I'm not sure does the problem has any connection to lto by default, probably not). I've just re-used the test provided in #71804 . Does it raise some problem here?
There was a problem hiding this comment.
I’ve had an issue on a system where lld’s version didn’t match that of the compiler. Uncommon scenario, but nevertheless it’s better to fix.
Currently BOLT finds LSDA secition by it's name .gcc_except_table.main . But sometimes it might have suffix e.g. .gcc_except_table.main. Find LSDA section by it's address, rather by it's name. Fixes llvm#71804
| @@ -0,0 +1,7 @@ | |||
| SECTIONS { | |||
| .text : { *(.text*) } | |||
There was a problem hiding this comment.
lld creates a PF_R PT_LOAD. For best portability, the first section of each segment should be specified. I created #93763
Currently BOLT finds LSDA secition by it's name .gcc_except_table.main .
But sometimes it might have suffix e.g. .gcc_except_table.main. Find
LSDA section by it's address, rather by it's name.
Fixes #71804