-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LoongArch][NFC] Pre-commit MCInstrAnalysis tests for instruction 'b' #71903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SixWeining . Looking forward to your review. Thanks. |
Seems the title and commit message are truncated. |
The tests for 'b' which commented with FIXME are incorrect, the following patch will fix it.
zhaoqi5
force-pushed
the
mcinstranalysis-instr-b-wrong
branch
from
November 15, 2023 01:59
011bba2
to
3372e7b
Compare
I have updated the commit and shorten the title. Thanks. |
SixWeining
approved these changes
Nov 15, 2023
zhaoqi5
changed the title
[LoongArch][NFC] Pre-commit tests for MCInstrAnalysis for instruction…
[LoongArch][NFC] Pre-commit MCInstrAnalysis tests for instruction 'b'
Nov 15, 2023
zhaoqi5
added a commit
to zhaoqi5/llvm-project
that referenced
this pull request
Nov 15, 2023
Instr "b offs26" represent to an unconditional branch in LoongArch. Set isBarrier to 1 in tablegen for it, so that MCInstrAnalysis can return correctly. Fixes llvm#71903.
SixWeining
pushed a commit
that referenced
this pull request
Nov 16, 2023
Instr "b offs26" represent to an unconditional branch in LoongArch. Set isBarrier to 1 in tablegen for it, so that MCInstrAnalysis can return correctly. Fixes #71903.
sr-tream
pushed a commit
to sr-tream/llvm-project
that referenced
this pull request
Nov 20, 2023
Instr "b offs26" represent to an unconditional branch in LoongArch. Set isBarrier to 1 in tablegen for it, so that MCInstrAnalysis can return correctly. Fixes llvm#71903.
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
…llvm#71903) The tests for 'b' which commented with FIXME are incorrect, the following patch will fix it.
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
Instr "b offs26" represent to an unconditional branch in LoongArch. Set isBarrier to 1 in tablegen for it, so that MCInstrAnalysis can return correctly. Fixes llvm#71903.
wanghao75
pushed a commit
to openeuler-mirror/llvm-project
that referenced
this pull request
Apr 9, 2024
Instr "b offs26" represent to an unconditional branch in LoongArch. Set isBarrier to 1 in tablegen for it, so that MCInstrAnalysis can return correctly. Fixes llvm/llvm-project#71903. (cherry picked from commit 42a4d5e8cab1537515d92ed56d6e17b673ed352f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for 'b' which commented with FIXME are incorrect, the following patch will fix it.