Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch][NFC] Pre-commit MCInstrAnalysis tests for instruction 'b' #71903

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

zhaoqi5
Copy link
Contributor

@zhaoqi5 zhaoqi5 commented Nov 10, 2023

The tests for 'b' which commented with FIXME are incorrect, the following patch will fix it.

@zhaoqi5
Copy link
Contributor Author

zhaoqi5 commented Nov 10, 2023

@SixWeining . Looking forward to your review. Thanks.

@SixWeining
Copy link
Contributor

Seems the title and commit message are truncated.

The tests for 'b' which commented with FIXME are incorrect,
the following patch will fix it.
@zhaoqi5 zhaoqi5 force-pushed the mcinstranalysis-instr-b-wrong branch from 011bba2 to 3372e7b Compare November 15, 2023 01:59
@zhaoqi5
Copy link
Contributor Author

zhaoqi5 commented Nov 15, 2023

Seems the title and commit message are truncated.

I have updated the commit and shorten the title. Thanks.

@SixWeining SixWeining self-requested a review November 15, 2023 03:07
@zhaoqi5 zhaoqi5 changed the title [LoongArch][NFC] Pre-commit tests for MCInstrAnalysis for instruction… [LoongArch][NFC] Pre-commit MCInstrAnalysis tests for instruction 'b' Nov 15, 2023
@SixWeining SixWeining merged commit f6c4bb0 into llvm:main Nov 15, 2023
2 of 3 checks passed
zhaoqi5 added a commit to zhaoqi5/llvm-project that referenced this pull request Nov 15, 2023
Instr "b offs26" represent to an unconditional branch in LoongArch.
Set isBarrier to 1 in tablegen for it, so that MCInstrAnalysis can
return correctly.

Fixes llvm#71903.
SixWeining pushed a commit that referenced this pull request Nov 16, 2023
Instr "b offs26" represent to an unconditional branch in LoongArch. Set
isBarrier to 1 in tablegen for it, so that MCInstrAnalysis can return
correctly.

Fixes #71903.
@zhaoqi5 zhaoqi5 deleted the mcinstranalysis-instr-b-wrong branch November 20, 2023 09:09
sr-tream pushed a commit to sr-tream/llvm-project that referenced this pull request Nov 20, 2023
Instr "b offs26" represent to an unconditional branch in LoongArch. Set
isBarrier to 1 in tablegen for it, so that MCInstrAnalysis can return
correctly.

Fixes llvm#71903.
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
…llvm#71903)

The tests for 'b' which commented with FIXME are incorrect, the
following patch will fix it.
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
Instr "b offs26" represent to an unconditional branch in LoongArch. Set
isBarrier to 1 in tablegen for it, so that MCInstrAnalysis can return
correctly.

Fixes llvm#71903.
wanghao75 pushed a commit to openeuler-mirror/llvm-project that referenced this pull request Apr 9, 2024
Instr "b offs26" represent to an unconditional branch in LoongArch. Set
isBarrier to 1 in tablegen for it, so that MCInstrAnalysis can return
correctly.

Fixes llvm/llvm-project#71903.

(cherry picked from commit 42a4d5e8cab1537515d92ed56d6e17b673ed352f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants