[Flang][OpenMP] Fix issue with empty critical or critical without surrounding context

[kiranchandramohan]

Add the sourcerange for critical directive.

Fixes #65571

[llvmbot]

@llvm/pr-subscribers-flang-openmp

@llvm/pr-subscribers-flang-semantics

Author: Kiran Chandramohan (kiranchandramohan)

Changes

Add the sourcerange for critical directive.

Fixes #65571

---

Full diff: https://github.com/llvm/llvm-project/pull/71944.diff

1 Files Affected:

• (modified) flang/lib/Semantics/resolve-names.cpp (+14)

diff --git a/flang/lib/Semantics/resolve-names.cpp b/flang/lib/Semantics/resolve-names.cpp
index 98773a1b9d6ab45..58d88f1bb428387 100644
--- a/flang/lib/Semantics/resolve-names.cpp
+++ b/flang/lib/Semantics/resolve-names.cpp
@@ -1452,6 +1452,20 @@ class OmpVisitor : public virtual DeclarationVisitor {
   void Post(const parser::OmpEndSectionsDirective &) {
     messageHandler().set_currStmtSource(std::nullopt);
   }
+  bool Pre(const parser::OmpCriticalDirective &x) {
+    AddOmpSourceRange(x.source);
+    return true;
+  }
+  void Post(const parser::OmpCriticalDirective &) {
+    messageHandler().set_currStmtSource(std::nullopt);
+  }
+  bool Pre(const parser::OmpEndCriticalDirective &x) {
+    AddOmpSourceRange(x.source);
+    return true;
+  }
+  void Post(const parser::OmpEndCriticalDirective &) {
+    messageHandler().set_currStmtSource(std::nullopt);
+  }
 };
 
 bool OmpVisitor::NeedsScope(const parser::OpenMPBlockConstruct &x) {

[DavidTruby]

Is there a way to add a test for this? For example could we use the example in the linked issue and check it doesn't error anymore?

[kiranchandramohan]

Is there a way to add a test for this? For example could we use the example in the linked issue and check it doesn't error anymore?

Have added a test.

[DavidTruby]

LGTM