[clang] -rdynamic option

[ghost]

-rdynamic option should not use with -static, as shown in the following code

llvm-project/clang/lib/Driver/ToolChains/Gnu.cpp

Lines 460 to 472 in f86770a

	if (IsStatic) {
	CmdArgs.push_back("-static");
	} else {
	if (Args.hasArg(options::OPT_rdynamic))
	CmdArgs.push_back("-export-dynamic");
	if (!Args.hasArg(options::OPT_shared) && !IsStaticPIE &&
	!Args.hasArg(options::OPT_r)) {
	CmdArgs.push_back("-dynamic-linker");
	CmdArgs.push_back(Args.MakeArgString(Twine(D.DyldPrefix) +
	ToolChain.getDynamicLinker(Args)));
	}
	}

So I think the code in line 420-421 should be deleted.

llvm-project/clang/lib/Driver/ToolChains/Gnu.cpp

Lines 420 to 421 in f86770a

	if (Args.hasArg(options::OPT_rdynamic))
	CmdArgs.push_back("-export-dynamic");

[llvmbot]

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-driver

Author: None (ls-Mou)

Changes

-rdynamic option should not use with -static, as shown in the following code

llvm-project/clang/lib/Driver/ToolChains/Gnu.cpp

Lines 460 to 472 in f86770a

	if (IsStatic) {
	CmdArgs.push_back("-static");
	} else {
	if (Args.hasArg(options::OPT_rdynamic))
	CmdArgs.push_back("-export-dynamic");
	if (!Args.hasArg(options::OPT_shared) && !IsStaticPIE &&
	!Args.hasArg(options::OPT_r)) {
	CmdArgs.push_back("-dynamic-linker");
	CmdArgs.push_back(Args.MakeArgString(Twine(D.DyldPrefix) +
	ToolChain.getDynamicLinker(Args)));
	}
	}

So I think the code in line 420-421 should be deleted.

llvm-project/clang/lib/Driver/ToolChains/Gnu.cpp

Lines 420 to 421 in f86770a

	if (Args.hasArg(options::OPT_rdynamic))
	CmdArgs.push_back("-export-dynamic");

---

Full diff: https://github.com/llvm/llvm-project/pull/72089.diff

1 Files Affected:

• (modified) clang/lib/Driver/ToolChains/Gnu.cpp (-3)

diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp
index 19dff4ec4d45e08..6c0041279de5a27 100644
--- a/clang/lib/Driver/ToolChains/Gnu.cpp
+++ b/clang/lib/Driver/ToolChains/Gnu.cpp
@@ -417,9 +417,6 @@ void tools::gnutools::Linker::ConstructJob(Compilation &C, const JobAction &JA,
     CmdArgs.push_back("text");
   }
 
-  if (Args.hasArg(options::OPT_rdynamic))
-    CmdArgs.push_back("-export-dynamic");
-
   if (Args.hasArg(options::OPT_s))
     CmdArgs.push_back("-s");