Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][RISCV] : The zcmt extension is already supported,but the documents related to riscv have not been updated #72115

Closed
wants to merge 1 commit into from

Conversation

whousemyname
Copy link

@whousemyname whousemyname commented Nov 13, 2023

This PR changes the status of RISC-V extension zcmt to supported.

0aecddc
In the above submission, zce has been supported, that is, zcmt is also supported in the backend of riscv, but the relevant documents about riscv have not been updated. This PR changes the extension status of zcmt to supported.

@llvmbot
Copy link
Collaborator

llvmbot commented Nov 13, 2023

@llvm/pr-subscribers-backend-risc-v

Author: jiangtao zhao (whousemyname)

Changes

This PR changes the extension status of zcmt to supported.

https://github.com/llvm/llvm-project/commit/0aecddcee98057300bdf2e2cd00f0eeefced3c81
In the above submission, zce has been supported, that is, zcmt is also supported in the backend of riscv, but the relevant documents about riscv have not been updated. This PR changes the extension status of zcmt to supported.


Full diff: https://github.com/llvm/llvm-project/pull/72115.diff

1 Files Affected:

  • (modified) llvm/docs/RISCVUsage.rst (+1-1)
diff --git a/llvm/docs/RISCVUsage.rst b/llvm/docs/RISCVUsage.rst
index e1d5557888bd071..1eb267c7dbe0c9c 100644
--- a/llvm/docs/RISCVUsage.rst
+++ b/llvm/docs/RISCVUsage.rst
@@ -109,7 +109,7 @@ on support follow.
      ``Zcd``          Supported
      ``Zcf``          Supported
      ``Zcmp``         Supported
-     ``Zcmt``         Assembly Support
+     ``Zcmt``         Supported
      ``Zdinx``        Supported
      ``Zfa``          Supported
      ``Zfh``          Supported

@michaelmaitland
Copy link
Contributor

michaelmaitland commented Nov 14, 2023

The link commit in description gives a 404 because it sends me to https://github.com/llvm/llvm-project/pull/url, but if I copy the text, then it brings me to the correct commit.

@topperc
Copy link
Collaborator

topperc commented Nov 14, 2023

The compiler will never emit a Zcmt instruction and as far as I know lld support isn't done. So I'm not sure what we want "Supported" to mean here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants