[clang] fix test PR69717.cpp #72134
Merged
[clang] fix test PR69717.cpp #72134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: antoine moynault (antmox) ChangesTest still fail on ARM machine (no float_control support) Full diff: https://github.com/llvm/llvm-project/pull/72134.diff 1 Files Affected:
diff --git a/clang/test/Sema/PR69717.cpp b/clang/test/Sema/PR69717.cpp
index 42a87bd1ac1ec8d..3d1290dcbc32b43 100644
--- a/clang/test/Sema/PR69717.cpp
+++ b/clang/test/Sema/PR69717.cpp
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -verify -fsyntax-only %s
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -verify -fsyntax-only %s
// REQUIRES: x86-registered-target
// expected-no-diagnostics
|
antmox
referenced
this pull request
Nov 13, 2023
The test Sema/PR69717.cpp fails on platforms that do not support pragma float_control. So run this test on x86 only.
|
@antmox Thank you for fixing that! |
|
No problem, thanks : ) |
|
did not wait for last tests. hope thats ok |
tru
pushed a commit
that referenced
this pull request
Nov 14, 2023
Test still fail on ARM machine (no float_control support) (cherry picked from commit 5fdb70b)
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
Test still fail on ARM machine (no float_control support)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test still fail on ARM machine (no float_control support)