Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flang][Doc] Add a FIROperations section #72252

Merged

Conversation

kiranchandramohan
Copy link
Contributor

Adding this section ensures that the documentation generated by mlir-tblgen for all the FIR operations are at the correct depth. FIROperations are at depth 3, the new section is at depth 2. This fixes the "Non-consecutive header level increase; H1 to H3" warning in FIRLangRef.md.

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Nov 14, 2023
@kiranchandramohan
Copy link
Contributor Author

This does not seem sufficient to fix the issue.

Adding this section ensures that the documentation generated by
mlir-tblgen for all the FIR operations are at the correct depth.
FIROperations are at depth 3, the new section is at depth 2.
This fixes the Non-consecutive header level increase; H1 to H3
in FIRLangRef.md.
@kiranchandramohan
Copy link
Contributor Author

This does not seem sufficient to fix the issue.

That turned out to be a whitespace issue. Now working and fixes the issue mentioned in the commit message.

Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kiranchandramohan kiranchandramohan merged commit 1d60d54 into llvm:main Nov 14, 2023
4 checks passed
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
Adding this section ensures that the documentation generated by
mlir-tblgen for all the FIR operations are at the correct depth.
FIROperations are at depth 3, the new section is at depth 2. This fixes
the "Non-consecutive header level increase; H1 to H3" warning in
FIRLangRef.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants