Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISCV] Omit "@plt" in assembly output "call foo@plt" #72467

Merged
merged 1 commit into from Jan 7, 2024
Merged

[RISCV] Omit "@plt" in assembly output "call foo@plt" #72467

merged 1 commit into from Jan 7, 2024

Commits on Jan 7, 2024

  1. [RISCV] Omit "@plt" in assembly output "call foo@plt" 

    R_RISCV_CALL/R_RISCV_CALL_PLT distinction is not necessary and
R_RISCV_CALL has been deprecated. Since https://reviews.llvm.org/D132530
`call foo` assembles to R_RISCV_CALL_PLT. The `@plt` suffix is not
useful and can be removed now (matching AArch64 and PowerPC).

GNU assembler assembles `call foo` to RISCV_CALL_PLT since 2022-09
(70f35d72ef04cd23771875c1661c9975044a749c).

Without this patch, unconditionally changing MO_CALL to MO_PLT could
create `jump .L1@plt, a0`, which is invalid in LLVM integrated assembler
and GNU assembler.
    @MaskRay
    MaskRay committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    0e554b4 View commit details
    Browse the repository at this point in the history