[BOLT] Use deterministic xxh3 for computing BF/BB hashes #72542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes is a "completed" version of #65437 with tests -- I didn't know how to commandeer the change so had to create a new PR |
aaupov
reviewed
Nov 27, 2023
| @@ -5,19 +5,28 @@ RUN: yaml2obj %p/Inputs/blarge.yaml &> %t.exe | |||
| # Testing "usqrt" | |||
| RUN: llvm-bolt %t.exe -o /dev/null --b %p/Inputs/blarge_profile_stale.yaml \ | |||
| RUN: --print-cfg --print-only=usqrt --infer-stale-profile=1 \ | |||
| RUN: --profile-ignore-hash=1 --profile-use-dfs=0 2>&1 | FileCheck %s -check-prefix=CHECK1 | |||
| RUN: --profile-ignore-hash=1 --profile-use-dfs=0 --debug-only=bolt-prof 2>&1 | FileCheck %s -check-prefix=CHECK1 | |||
There was a problem hiding this comment.
Please add REQUIRES: asserts for debug logging checks
spupyrev
requested review from
antiagainst,
kuhar,
MaheshRavishankar,
JDevlieghere,
nikic and
a team
as code owners
spupyrev
force-pushed
the
bolt-deterministic-hashing
branch
3 times, most recently
from
fc69580
to
6926ed2
Compare
spupyrev
removed request for
a team,
nikic,
antiagainst,
JDevlieghere,
MaheshRavishankar and
kuhar
spupyrev
force-pushed
the
bolt-deterministic-hashing
branch
from
d888bb3
to
5cb1a1d
Compare
aaupov
approved these changes
Nov 27, 2023
spupyrev
force-pushed
the
bolt-deterministic-hashing
branch
from
5cb1a1d
to
9156275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::hash and ADT/Hashing::hash_value are non-deterministic functions whose
results might vary across implementation/process/execution. Using xxh3 instead
for computing hashes of BinaryFunctions and BinaryBasicBlock for stale profile
matching.
(A possible alternative is to use ADT/StableHashing.h based on FNV hashing but
xxh3 seems to be more popular in LLVM)
This is to address #65241.