Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readtapi] Add Merge functionality #72656

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

cyndyishida
Copy link
Member

@cyndyishida cyndyishida commented Nov 17, 2023

Merge allows a user to merge different files (tbds for now or dylibs in the future) to emit out a single tbd with all input contents. This does require that all inputs represent the same library.

Merge allows a user to merge different files (tbds or dylibs) to emit
out a single tbd with all input contents. This does require that all
inputs represent the same library.
Copy link
Collaborator

@ributzka ributzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Cyndy for getting this all upstreamed. I have a few minor comments/questions inline.

llvm/include/llvm/TextAPI/TextAPIWriter.h Outdated Show resolved Hide resolved
llvm/test/tools/llvm-readtapi/merge.test Show resolved Hide resolved
llvm/tools/llvm-readtapi/llvm-readtapi.cpp Outdated Show resolved Hide resolved
llvm/tools/llvm-readtapi/llvm-readtapi.cpp Outdated Show resolved Hide resolved
llvm/tools/llvm-readtapi/llvm-readtapi.cpp Show resolved Hide resolved
llvm/tools/llvm-readtapi/llvm-readtapi.cpp Outdated Show resolved Hide resolved
llvm/tools/llvm-readtapi/llvm-readtapi.cpp Outdated Show resolved Hide resolved
* Add a helper function for boilerplate fatal error handling.
* Add a simple & implicit writeAction
Copy link
Collaborator

@ributzka ributzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Cyndy. LGTM

@cyndyishida cyndyishida merged commit ae182db into llvm:main Nov 17, 2023
3 checks passed
sr-tream pushed a commit to sr-tream/llvm-project that referenced this pull request Nov 20, 2023
Merge allows a user to merge different files (tbds for now or dylibs in
the future) to emit out a single tbd with all input contents. This does
require that all inputs represent the same library.
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
Merge allows a user to merge different files (tbds for now or dylibs in
the future) to emit out a single tbd with all input contents. This does
require that all inputs represent the same library.
cyndyishida added a commit to cyndyishida/llvm-project that referenced this pull request Jan 4, 2024
Merge allows a user to merge different files (tbds for now or dylibs in
the future) to emit out a single tbd with all input contents. This does
require that all inputs represent the same library.

(cherry picked from commit ae182db)
cyndyishida added a commit to apple/llvm-project that referenced this pull request Jan 5, 2024
Merge allows a user to merge different files (tbds for now or dylibs in
the future) to emit out a single tbd with all input contents. This does
require that all inputs represent the same library.

(cherry picked from commit ae182db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants