[AArch64] Update LangRef to reference GHC calling convention #72760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArch64 has supported the GHC calling convention for quite a few years at this point, but the LangRef never got updated noting that this was implemented on AArch64.
|
@llvm/pr-subscribers-llvm-ir Author: Aiden Grossman (boomanaiden154) ChangesAArch64 has supported the GHC calling convention for quite a few years at this point (https://reviews.llvm.org/D6877), but the LangRef never got updated noting that this was implemented on AArch64. Full diff: https://github.com/llvm/llvm-project/pull/72760.diff 1 Files Affected:
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
index bc1eab1e0b7a07f..886e0c8e6edd7c8 100644
--- a/llvm/docs/LangRef.rst
+++ b/llvm/docs/LangRef.rst
@@ -317,13 +317,16 @@ added in the future:
not be used lightly but only for specific situations such as an
alternative to the *register pinning* performance technique often
used when implementing functional programming languages. At the
- moment only X86 supports this convention and it has the following
- limitations:
+ moment only X86 and AArch64 support this convention. The following
+ limitations exist:
- - On *X86-32* only supports up to 4 bit type parameters. No
+ - On *X86-32* only up to 4 bit type parameters are supported. No
floating-point types are supported.
- - On *X86-64* only supports up to 10 bit type parameters and 6
- floating-point parameters.
+ - On *X86-64* only up to 10 bit type parameters and 6
+ floating-point parameters are supported.
+ - On *AArch64* only up to 4 32-bit floating-point parameters,
+ 4 64-bit floating-point parameters, and 10 bit type parameters
+ are supported.
This calling convention supports `tail call
optimization <CodeGenerator.html#tail-call-optimization>`_ but requires
|
|
Bump on this when reviewers have a chance. Thanks! |
davemgreen
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AArch64 has supported the GHC calling convention for quite a few years at this point (https://reviews.llvm.org/D6877), but the LangRef never got updated noting that this was implemented on AArch64.