[llvm] Specialize 'NoCFIValue::getType()'

[JOE1994]

Specialize NoCFIValue::getType() to give a more detailed type hint to clients.

[llvmbot]

@llvm/pr-subscribers-llvm-ir

Author: Youngsuk Kim (JOE1994)

Changes

Specialize NoCFIValue::getType() to give a more detailed type hint to clients.

---

Full diff: https://github.com/llvm/llvm-project/pull/72923.diff

1 Files Affected:

• (modified) llvm/include/llvm/IR/Constants.h (+5)

diff --git a/llvm/include/llvm/IR/Constants.h b/llvm/include/llvm/IR/Constants.h
index c443ec58822b007..48890593ce1a9ed 100644
--- a/llvm/include/llvm/IR/Constants.h
+++ b/llvm/include/llvm/IR/Constants.h
@@ -975,6 +975,11 @@ class NoCFIValue final : public Constant {
     return cast<GlobalValue>(Op<0>().get());
   }
 
+  /// NoCFIValue is always a pointer.
+  inline PointerType *getType() const {
+    return cast<PointerType>(Value::getType());
+  }
+
   /// Methods for support type inquiry through isa, cast, and dyn_cast:
   static bool classof(const Value *V) {
     return V->getValueID() == NoCFIValueVal;

[nikic]

LGTM

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff 44c796d5669e78dc020fc4b00865ed6fea42dd4d e10971f91cba1c1da658ab171f5bff52b3db8bcb -- llvm/include/llvm/IR/Constants.h

View the diff from clang-format here.

diff --git a/llvm/include/llvm/IR/Constants.h b/llvm/include/llvm/IR/Constants.h
index 2f7fc5652c..b4c43794a5 100644
--- a/llvm/include/llvm/IR/Constants.h
+++ b/llvm/include/llvm/IR/Constants.h
@@ -976,9 +976,7 @@ public:
   }
 
   /// NoCFIValue is always a pointer.
-  PointerType *getType() const {
-    return cast<PointerType>(Value::getType());
-  }
+  PointerType *getType() const { return cast<PointerType>(Value::getType()); }
 
   /// Methods for support type inquiry through isa, cast, and dyn_cast:
   static bool classof(const Value *V) {