Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-format] Also include libc++ extensionless headers #73142

Merged

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Nov 22, 2023

These headers were skipped by the job because they didn't have an extension. However, such headers are extremely common in libc++.

As a drive-by change, also include .cppm and .inc extensions since those are also common in libc++.

These headers were skipped by the job because they didn't have an
extension. However, such headers are extremely common in libc++.
Copy link

github-actions bot commented Nov 22, 2023

✅ With the latest revision this PR passed the Python code formatter.

Copy link
Contributor

@philnik777 philnik777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

llvm/utils/git/code-format-helper.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@tru tru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mordante mordante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@ldionne ldionne merged commit 3e28e1e into llvm:main Nov 22, 2023
2 of 3 checks passed
@ldionne ldionne deleted the review/code-format-include-extensionless-headers branch November 22, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants