[CodeGen] Split off PseudoSourceValueManager into separate header (NFC) #73327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
RKSimon
reviewed
Nov 24, 2023
| @@ -11,6 +11,7 @@ | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #include "llvm/CodeGen/PseudoSourceValue.h" | |||
| #include "llvm/CodeGen/PseudoSourceValueManager.h" | |||
There was a problem hiding this comment.
Fix clang-format warning (include order)
There was a problem hiding this comment.
I wasn't sure about this one. We usually place the header corresponding to the source file first in the include list, and in this case that's two different headers, not just one.
|
ping |
Most users of PseudoSourceValue.h only need PseudoSourceValue, not the PseudoSourceValueManager. However, this header pulls in some very expensive dependenceis like ValueMap.h, which is only used for the manager. Split off the manager into a separate header and include it only where used.
nikic
force-pushed
the
split-pseudo-source-value
branch
from
1616cbb
to
73c282d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most users of PseudoSourceValue.h only need PseudoSourceValue, not the PseudoSourceValueManager. However, this header pulls in some very expensive dependencies like ValueMap.h, which is only used for the manager.
Split off the manager into a separate header and include it only where used.