[JITLink][AArch32] Draft fixture class for fixup tests and out-of-range errors in particular #73397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
weliveindetail
force-pushed
the
jitlink-aarch32-fixup-test-fixture
branch
from
9129999
to
f4d92c8
Compare
eymay
approved these changes
Nov 29, 2023
|
|
||
| // Check that branching to an ARM target with Jump24 fails | ||
| Symbol &ArmTarget = createSymbolWithDistance(Site, 0x1000); | ||
| assert((J1J2Target.getTargetFlags() & TargetFlags_aarch32::ThumbSymbol) == 0); |
There was a problem hiding this comment.
I think you meant ArmTarget here
There was a problem hiding this comment.
Thanks! Fixed
…b Call and Jump24
weliveindetail
force-pushed
the
jitlink-aarch32-fixup-test-fixture
branch
from
f4d92c8
to
24d02cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design draft for testing out-of-range errors and packing helper functions into a gtest fixture:
https://github.com/google/googletest/blob/main/docs/primer.md#test-fixtures-using-the-same-data-configuration-for-multiple-tests-same-data-multiple-tests