Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOLT][NFC] Refactor function state check #73420

Merged
merged 2 commits into from
Nov 26, 2023
Merged

[BOLT][NFC] Refactor function state check #73420

merged 2 commits into from
Nov 26, 2023

Conversation

maksfb
Copy link
Contributor

@maksfb maksfb commented Nov 26, 2023 •
edited

Remove redundant check in updateOutputValues().

@maksfb
[BOLT][NFC] Refactor function state check
c3ed683 
Properly check function emission state in updateOutputValues().
@maksfb maksfb added the BOLT label Nov 26, 2023
aaupov
aaupov approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding: we were testing the conditions used for emission rather than the actual emitted state of BF, and this diff fixes it, right?
Which cases did we miss where the function was simple but wasn't emitted?

@maksfb
Copy link
Contributor Author

maksfb commented Nov 26, 2023

Just for my understanding: we were testing the conditions used for emission rather than the actual emitted state of BF, and this diff fixes it, right? Which cases did we miss where the function was simple but wasn't emitted?

This PR is pure NFC to improve readability. Actually, @ShatianWang pointed out that the same check is executed at the beginning of the function. I.e. the check is redundant and I'm going to remove it.

@maksfb maksfb merged commit 3651142 into llvm:main Nov 26, 2023
3 checks passed
@maksfb maksfb deleted the gh-update-output-nfc branch November 29, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaupov aaupov aaupov approved these changes

@ShatianWang ShatianWang ShatianWang approved these changes

@rafaelauler rafaelauler Awaiting requested review from rafaelauler rafaelauler is a code owner

Assignees
No one assigned
Labels
BOLT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maksfb @aaupov @ShatianWang