Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT][DWARF] Fix output ranges for deleted code #73464

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

maksfb
Copy link
Contributor

@maksfb maksfb commented Nov 26, 2023

Set range low_pc to 0 for DIEs that correspond to deleted code.

Fixes #73428

@maksfb maksfb added the BOLT label Nov 26, 2023
@maksfb maksfb requested a review from ayermolo November 26, 2023 21:59
@maksfb maksfb marked this pull request as ready for review November 28, 2023 20:03
Copy link
Contributor

@ayermolo ayermolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayermolo
Copy link
Contributor

ayermolo commented Nov 28, 2023

Can you add DWARF5 test?
Also can you change dwarf-deleted-range.s to dwarf4-deleted-range.s

Set range low_pc to 0 for DIEs that correspond to deleted code.

Fixes llvm#73428
@maksfb maksfb merged commit 0acfe84 into llvm:main Nov 29, 2023
3 checks passed
@maksfb maksfb deleted the gh-dwarf-dix-deleted-range branch November 29, 2023 06:42
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Nov 30, 2023
Local branch amd-gfx 4938c62 Merged main:9c5003cc0c70 into amd-gfx:606d2d42f73e
Remote branch main 0acfe84 [BOLT][DWARF] Fix output ranges for deleted code (llvm#73464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BOLT][DWARF] Output ranges not properly updated for deleted basic blocks
2 participants