[NFC][indvars] Remove unused code in WidenIV::widenLoopCompare #73506

wenju-he · 2023-11-27T11:38:56Z

No description provided.

github-actions · 2023-11-27T11:43:06Z

✅ With the latest revision this PR passed the C/C++ code formatter.

llvmbot · 2023-11-29T23:47:49Z

@llvm/pr-subscribers-llvm-transforms

Author: Wenju He (wenju-he)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/73506.diff

1 Files Affected:

(modified) llvm/lib/Transforms/Utils/SimplifyIndVar.cpp (-4)

diff --git a/llvm/lib/Transforms/Utils/SimplifyIndVar.cpp b/llvm/lib/Transforms/Utils/SimplifyIndVar.cpp
index a23ac41acaa58aa..a1d09fd73c29129 100644
--- a/llvm/lib/Transforms/Utils/SimplifyIndVar.cpp
+++ b/llvm/lib/Transforms/Utils/SimplifyIndVar.cpp
@@ -1493,10 +1493,6 @@ bool WidenIV::widenLoopCompare(WidenIV::NarrowIVDefUse DU) {
   assert(CastWidth <= IVWidth && "Unexpected width while widening compare.");
 
   // Widen the compare instruction.
-  auto *InsertPt = getInsertPointForUses(DU.NarrowUse, DU.NarrowDef, DT, LI);
-  if (!InsertPt)
-    return false;
-  IRBuilder<> Builder(InsertPt);
   DU.NarrowUse->replaceUsesOfWith(DU.NarrowDef, DU.WideDef);
 
   // Widen the other operand of the compare, if necessary.

wenju-he · 2023-11-29T23:49:43Z

CI clang-format error isn't related to this pr:

Running: git-clang-format --diff f[21](https://github.com/llvm/llvm-project/actions/runs/7004455642/job/19052227219?pr=73506#step:10:22)a70f9fe21539f70212ba[23](https://github.com/llvm/llvm-project/actions/runs/7004455642/job/19052227219?pr=73506#step:10:24)46c3db54f4d9980 c9808bf052d7ae13c3a8fb7678bdd[25](https://github.com/llvm/llvm-project/actions/runs/7004455642/job/19052227219?pr=73506#step:10:26)73a00deb9 -- llvm/lib/Transforms/Utils/SimplifyIndVar.cpp
error: clang-format exited with code 1
diff --git a/llvm/lib/Transforms/Utils/SimplifyIndVar.cpp b/llvm/lib/Transforms/Utils/SimplifyIndVar.cpp
index a1d09fd73c..47ecc89055 100644
--- a/llvm/lib/Transforms/Utils/SimplifyIndVar.cpp
+++ b/llvm/lib/Transforms/Utils/SimplifyIndVar.cpp
@@ -1[37](https://github.com/llvm/llvm-project/actions/runs/7004455642/job/19052227219?pr=73506#step:10:38)9,10 +1379,10 @@ WidenIV::getExtendedOperandRecurrence(WidenIV::NarrowIVDefUse DU) {
   ExtendKind ExtKind = getExtendKind(DU.NarrowDef);
   if (ExtKind == ExtendKind::Sign && OBO->hasNoSignedWrap())
     ExtendOperExpr = SE->getSignExtendExpr(
-      SE->getSCEV(DU.NarrowUse->getOperand(ExtendOperIdx)), WideType);
+        SE->getSCEV(DU.NarrowUse->getOperand(ExtendOperIdx)), WideType);
   else if (ExtKind == ExtendKind::Zero && OBO->hasNoUnsignedWrap())
     ExtendOperExpr = SE->getZeroExtendExpr(
-      SE->getSCEV(DU.NarrowUse->getOperand(ExtendOperIdx)), WideType);
+        SE->getSCEV(DU.NarrowUse->getOperand(ExtendOperIdx)), WideType);
   else
     return {nullptr, ExtendKind::Unknown};
 

error: some formatters failed: clang-format
Error: Process completed with exit code 1.

boomanaiden154 · 2023-11-30T00:05:49Z

That clang-format diff seems to be coming from 7c93452. Not sure why that's getting picked up.

I've opened an issue at #73873 as this shouldn't be happening. I'm guessing if you rebase against a recent main, the immediate issue will be fixed while investigation/work is done on fixing the underlying issue in the CI.

wenju-he · 2023-11-30T00:24:40Z

That clang-format diff seems to be coming from 7c93452. Not sure why that's getting picked up.

I've opened an issue at #73873 as this shouldn't be happening. I'm guessing if you rebase against a recent main, the immediate issue will be fixed while investigation/work is done on fixing the underlying issue in the CI.

thank you @boomanaiden154 for the analysis. clang-format check passed after rebase.

However, there is new error:

<html>
<body>
<!--StartFragment-->
$ git clean -ffxdq
--
  | # Fetch and checkout pull request head from GitHub
  | $ git fetch -v --prune -- origin refs/pull/73506/head
  | POST git-upload-pack (401 bytes)
  | POST git-upload-pack (943 bytes)
  | POST git-upload-pack (gzip 2543 to 1316 bytes)
  | POST git-upload-pack (gzip 5743 to 2922 bytes)
  | POST git-upload-pack (gzip 12143 to 6112 bytes)
  | remote: Enumerating objects: 7, done.
  | remote: Counting objects: 100% (6/6), done.
  | remote: Total 7 (delta 6), reused 6 (delta 6), pack-reused 1
  | Unpacking objects: 100% (7/7), 7.25 KiB \| 200.00 KiB/s, done.
  | From https://github.com/llvm/llvm-project
  | * branch                      refs/pull/73506/head -> FETCH_HEAD
  | # FETCH_HEAD is now `c9808bf052d7ae13c3a8fb7678bdd2573a00deb9`
  | $ git checkout -f b77f90718a325c0ead0e041aed31f3ee7cf8cc56
  | fatal: reference is not a tree: b77f90718a325c0ead0e041aed31f3ee7cf8cc56
  | ⚠️ Warning: Checkout failed! checking out commit "b77f90718a325c0ead0e041aed31f3ee7cf8cc56": exit status 128 (Attempt 1/3 Retrying in 2s)
  | $ git clean -ffxdq
  | # Fetch and checkout pull request head from GitHub
  | $ git fetch -v --prune -- origin refs/pull/73506/head
  | POST git-upload-pack (401 bytes)
  | From https://github.com/llvm/llvm-project
  | * branch                      refs/pull/73506/head -> FETCH_HEAD
  | # FETCH_HEAD is now `c9808bf052d7ae13c3a8fb7678bdd2573a00deb9`
  | $ git checkout -f b77f90718a325c0ead0e041aed31f3ee7cf8cc56
  | fatal: reference is not a tree: b77f90718a325c0ead0e041aed31f3ee7cf8cc56
  | ⚠️ Warning: Checkout failed! checking out commit "b77f90718a325c0ead0e041aed31f3ee7cf8cc56": exit status 128 (Attempt 2/3 Retrying in 2s)
  | $ git clean -ffxdq
  | # Fetch and checkout pull request head from GitHub
  | $ git fetch -v --prune -- origin refs/pull/73506/head
  | POST git-upload-pack (401 bytes)
  | From https://github.com/llvm/llvm-project
  | * branch                      refs/pull/73506/head -> FETCH_HEAD
  | # FETCH_HEAD is now `c9808bf052d7ae13c3a8fb7678bdd2573a00deb9`
  | $ git checkout -f b77f90718a325c0ead0e041aed31f3ee7cf8cc56
  | fatal: reference is not a tree: b77f90718a325c0ead0e041aed31f3ee7cf8cc56
  | ⚠️ Warning: Checkout failed! checking out commit "b77f90718a325c0ead0e041aed31f3ee7cf8cc56": exit status 128 (Attempt 3/3)
  | 🚨 Error: checking out commit "b77f90718a325c0ead0e041aed31f3ee7cf8cc56": exit status 128

<!--EndFragment-->
</body>
</html>

@boomanaiden154 Do you have any idea about this error? Thank you

boomanaiden154 · 2023-11-30T00:28:17Z

@boomanaiden154 Do you have any idea about this error? Thank you

No, I don't. As long as your tests pass locally, I wouldn't worry too much about the Buildkite failure. In a couple days the infrastructure for that should be getting migrated to Github actions now that Phabricator CI support is going away, so there's not going to be a lot of effort put into fixing these sorts of things on the Buildkite site.

wenju-he · 2023-11-30T00:50:05Z

@boomanaiden154 Do you have any idea about this error? Thank you

No, I don't. As long as your tests pass locally, I wouldn't worry too much about the Buildkite failure. In a couple days the infrastructure for that should be getting migrated to Github actions now that Phabricator CI support is going away, so there's not going to be a lot of effort put into fixing these sorts of things on the Buildkite site.

Thank you.

nikic

LGTM

wenju-he marked this pull request as ready for review November 29, 2023 23:47

llvmbot added the llvm:transforms label Nov 29, 2023

boomanaiden154 mentioned this pull request Nov 30, 2023

Clang format action picking up diffs from other commits #73873

Closed

wenju-he force-pushed the indvars-dead-code branch from c9808bf to b77f907 Compare November 30, 2023 00:17

wenju-he force-pushed the indvars-dead-code branch from b77f907 to 694ec02 Compare November 30, 2023 00:29

[NFC][indvars] Remove unused code in WidenIV::widenLoopCompare

aa5e726

wenju-he force-pushed the indvars-dead-code branch from 694ec02 to aa5e726 Compare November 30, 2023 01:11

nikic approved these changes Nov 30, 2023

View reviewed changes

yubingex007-a11y merged commit 2441e23 into llvm:main Dec 1, 2023
3 checks passed

wenju-he deleted the indvars-dead-code branch December 1, 2023 01:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NFC][indvars] Remove unused code in WidenIV::widenLoopCompare #73506

[NFC][indvars] Remove unused code in WidenIV::widenLoopCompare #73506

wenju-he commented Nov 27, 2023

github-actions bot commented Nov 27, 2023 •

edited

llvmbot commented Nov 29, 2023

wenju-he commented Nov 29, 2023

boomanaiden154 commented Nov 30, 2023

wenju-he commented Nov 30, 2023

boomanaiden154 commented Nov 30, 2023

wenju-he commented Nov 30, 2023

nikic left a comment

[NFC][indvars] Remove unused code in WidenIV::widenLoopCompare #73506

[NFC][indvars] Remove unused code in WidenIV::widenLoopCompare #73506

Conversation

wenju-he commented Nov 27, 2023

github-actions bot commented Nov 27, 2023 • edited

llvmbot commented Nov 29, 2023

wenju-he commented Nov 29, 2023

boomanaiden154 commented Nov 30, 2023

wenju-he commented Nov 30, 2023

boomanaiden154 commented Nov 30, 2023

wenju-he commented Nov 30, 2023

nikic left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 27, 2023 •

edited