Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang] Fix Funderscoring TC failure on AIX [NFC] #73543

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

madanial0
Copy link
Contributor

Change fundersoring test with a more accurate regex to ensure the lack of a trailing underscore, current TC is failing on AIX

@madanial0 madanial0 added the flang Flang issues not falling into any other category label Nov 27, 2023
@madanial0 madanial0 self-assigned this Nov 27, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Nov 27, 2023

@llvm/pr-subscribers-flang-driver

Author: None (madanial0)

Changes

Change fundersoring test with a more accurate regex to ensure the lack of a trailing underscore, current TC is failing on AIX


Full diff: https://github.com/llvm/llvm-project/pull/73543.diff

1 Files Affected:

  • (modified) flang/test/Driver/underscoring.f90 (+1-1)
diff --git a/flang/test/Driver/underscoring.f90 b/flang/test/Driver/underscoring.f90
index 7c03d040504ea54..8a9ed80ea4daba1 100644
--- a/flang/test/Driver/underscoring.f90
+++ b/flang/test/Driver/underscoring.f90
@@ -21,4 +21,4 @@ subroutine test()
 ! NO-UNDERSCORING-NOT: ext_sub_
 ! NO-UNDERSCORING: {{ext_sub[^_]*$}}
 ! NO-UNDERSCORING-NOT: comblk_
-! NO-UNDERSCORING: comblk,
+! NO-UNDERSCORING: {{comblk[^_]*$}}

@banach-space
Copy link
Contributor

Changes in write-module.f90 look unrelated.

Also, what's the output for AIX? How is it different from what's being tested?

@madanial0
Copy link
Contributor Author

madanial0 commented Nov 27, 2023

Changes in write-module.f90 look unrelated.

Creating a new PR for those changes

Also, what's the output for AIX? How is it different from what's being tested?

In AIX the output is comblk_[RW], for the funderscoring and comblk[RW], with the fnounderscoring which fails as it checks for comblk,

Copy link
Contributor

@banach-space banach-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@madanial0 madanial0 merged commit 4f0bea4 into llvm:main Nov 30, 2023
3 checks passed
@madanial0 madanial0 deleted the funderscoringfix branch November 30, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:driver flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants