Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang] changes where a test writes its output #73560

Closed
wants to merge 1 commit into from

Conversation

cjdb
Copy link
Contributor

@cjdb cjdb commented Nov 27, 2023

Writing directly to /dev/null has permission issues on some systems, so we've changed this to a temporary file instead.

Writing directly to /dev/null has permission issues on some systems, so
we've changed this to a temporary file instead.
@cjdb cjdb requested a review from slackito November 27, 2023 20:09
@cjdb cjdb closed this Nov 27, 2023
@cjdb cjdb deleted the OpenMP-test branch November 27, 2023 20:18
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:openmp OpenMP related changes to Clang labels Nov 27, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Nov 27, 2023

@llvm/pr-subscribers-clang

Author: Christopher Di Bella (cjdb)

Changes

Writing directly to /dev/null has permission issues on some systems, so we've changed this to a temporary file instead.


Full diff: https://github.com/llvm/llvm-project/pull/73560.diff

1 Files Affected:

  • (modified) clang/test/OpenMP/dispatch_unsupported.c (+1-1)
diff --git a/clang/test/OpenMP/dispatch_unsupported.c b/clang/test/OpenMP/dispatch_unsupported.c
index fe7ccfa90a5831a..729c046e2635ee4 100644
--- a/clang/test/OpenMP/dispatch_unsupported.c
+++ b/clang/test/OpenMP/dispatch_unsupported.c
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -emit-llvm -fopenmp -disable-llvm-passes %s -o /dev/null -verify=expected
+// RUN: %clang_cc1 -emit-llvm -fopenmp -disable-llvm-passes %s -o %t -verify=expected
 
 // expected-error@+2 {{cannot compile this OpenMP dispatch directive yet}}
 void a(){

@MaskRay
Copy link
Member

MaskRay commented Nov 27, 2023

b9b627f already fixed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:openmp OpenMP related changes to Clang clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants