[Flang] Testcase changes to switch directories before rm (NFC) #73602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-flang-driver Author: None (madanial0) ChangesIn AIX, the following TC fails in attempt to delete the current directory, exiting current directory before removing Full diff: https://github.com/llvm/llvm-project/pull/73602.diff 1 Files Affected:
diff --git a/flang/test/Driver/write-module.f90 b/flang/test/Driver/write-module.f90
index 0be5c5817ba9037..cf4be4306b6f569 100644
--- a/flang/test/Driver/write-module.f90
+++ b/flang/test/Driver/write-module.f90
@@ -9,6 +9,7 @@
! RUN: rm -rf %t && mkdir -p %t/dir-flang
! RUN: cd %t && %flang -fsyntax-only -module-dir %t/dir-flang %s
! RUN: ls %t/dir-flang/testmodule.mod && not ls %t/testmodule.mod
+! RUN: cd ..
!--------------------------
! -module-dir<value>
@@ -16,6 +17,7 @@
! RUN: rm -rf %t && mkdir -p %t/dir-flang
! RUN: cd %t && %flang -fsyntax-only -module-dir%t/dir-flang %s
! RUN: ls %t/dir-flang/testmodule.mod && not ls %t/testmodule.mod
+! RUN: cd ..
!---------------------------
! -J <value>
@@ -23,6 +25,7 @@
! RUN: rm -rf %t && mkdir -p %t/dir-flang
! RUN: cd %t && %flang -fsyntax-only -J %t/dir-flang %s
! RUN: ls %t/dir-flang/testmodule.mod && not ls %t/testmodule.mod
+! RUN: cd ..
!------------------------------
! -J<value>
@@ -30,6 +33,7 @@
! RUN: rm -rf %t && mkdir -p %t/dir-flang
! RUN: cd %t && %flang -fsyntax-only -J%t/dir-flang %s
! RUN: ls %t/dir-flang/testmodule.mod && not ls %t/testmodule.mod
+! RUN: cd ..
module testmodule
type::t2
|
|
What's TC? :) Also, wouldn't |
madanial0
changed the title
TC is test case, I switched it to avoid confusions sorry! I agree |
madanial0
force-pushed
the
write-module-cd
branch
from
050cc48
to
cbc90af
Compare
madanial0
force-pushed
the
write-module-cd
branch
from
cbc90af
to
4e70efb
Compare
|
@madanial0 Do you have commit access? If yes then it's fine to land this. If not, I can land it for you ;-) |
I do, I was just waiting for the latest checks after rebase |
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Dec 7, 2023
Local branch amd-gfx 3660ee5 Merged main:c13f7e17409b into amd-gfx:abbd8f9cb6f8 Remote branch main 9a485b0 [Flang] Testcase changes to switch directories before rm (NFC) (llvm#73602)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AIX, the following testcase fails in attempt to delete the current directory, exiting current directory before removing