Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Always define runtimes-test-depends #73629

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[CMake] Always define runtimes-test-depends #73629

merged 1 commit into from
Nov 28, 2023

Conversation

petrhosek
Copy link
Member

This allows the parent build to depend on this target unconditionally even when the tests are disabled.

@petrhosek
[CMake] Always define runtimes-test-depends
3858bb8 
This allows the parent build to depend on this target unconditionally
even when the tests are disabled.
@petrhosek petrhosek requested a review from a team as a code owner November 28, 2023 09:33
@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Nov 28, 2023
@petrhosek petrhosek mentioned this pull request Nov 28, 2023
Closed
@tstellar
Copy link
Collaborator

This fixes the test-depends target, which would allow us to re-commit 7f215b1.

With the config I was testing in #73610, the check-runtimes target still gives an error:

[4/5] cd /home/fedora/llvm-project/android-build/runtimes/runtimes-aarch64-linux-and...imes/runtimes-aarch64-linux-android21-bins/ --target check-runtimes --config Release
ninja: error: unknown target 'check-runtimes'

This is not a regression, though, the check-runtimes target also fails in latest main branch with this config.

@petrhosek
Copy link
Member Author

@tstellar Is it OK with you if I merge this change? I'll look into the check-runtimes issue separately.

tstellar
tstellar approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@tstellar tstellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@petrhosek petrhosek merged commit 4701f77 into llvm:main Nov 28, 2023
36 of 39 checks passed
@petrhosek petrhosek deleted the runtimes-test-depends-unconditional branch December 1, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstellar tstellar tstellar approved these changes

@ldionne ldionne ldionne approved these changes

Assignees
No one assigned
Labels
cmake Build system in general and CMake in particular
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@petrhosek @tstellar @ldionne @llvmbot