Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure lli --force-interpreter disables the OrcJIT too #73717

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

allight
Copy link
Contributor

@allight allight commented Nov 28, 2023

Unless the OrcJIT was explicitly disabled it would be used by lli even if the --force-interpreter flag was passed.

Unless the ORCJit was explicitly disabled it would be used by lli even
if the --force-interpreter flag was passed.
@zmodem zmodem requested a review from lhames December 1, 2023 10:05
@zmodem
Copy link
Collaborator

zmodem commented Dec 1, 2023

Looks very reasonable to me, but it's not really my area. @lhames can you double check?

Copy link
Contributor

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Thanks @allight!

@nvoorhies nvoorhies merged commit 0f45e45 into llvm:main Dec 5, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants