Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] Remove linux Buildkite builders entirely #73825

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

EricWF
Copy link
Member

@EricWF EricWF commented Nov 29, 2023

This removes the Google hosted Linux buildkite builders. We have since moved all of them over to github actions.

Follow up changes will be sent for android.

@EricWF EricWF requested a review from a team as a code owner November 29, 2023 17:18
@llvmbot llvmbot added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. github:workflow labels Nov 29, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Nov 29, 2023

@llvm/pr-subscribers-github-workflow

@llvm/pr-subscribers-libcxx

Author: Eric (EricWF)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/73825.diff

2 Files Affected:

  • (modified) .github/workflows/libcxx-build-and-test.yaml (+4)
  • (modified) libcxx/utils/ci/buildkite-pipeline.yml (-14)
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index dccfe54d4646767..5204fb4569ed309 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -158,6 +158,10 @@ jobs:
           'generic-no-wide-characters',
           'generic-static',
           'generic-with_llvm_unwinder'
+          # TODO Find a better place for the benchmark and bootstrapping builds to live. They're either very expensive
+          # or don't provide much value since the benchmark run results are too noise on the bots.
+          'benchmarks',
+          'bootstrapping-build',
         ]
         machine: [ 'libcxx-runners-8' ]
         std_modules: [ 'OFF' ]
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index 3c49247ab5aeeb9..7077f754220eb21 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -101,20 +101,6 @@ environment_definitions:
 
 
 steps:
-- label: Bootstrapping build
-  command: libcxx/utils/ci/run-buildbot bootstrapping-build
-  env:
-    <<: *common_env
-  <<: *linux_agent
-  <<: *common
-
-- label: Benchmarks
-  command: libcxx/utils/ci/run-buildbot benchmarks
-  env:
-    <<: *common_env
-  <<: *linux_agent
-  <<: *common
-
 - group: ':windows: Windows'
   steps:
   - label: Clang-cl (DLL)

Copy link
Member Author

@EricWF EricWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to commit this once the bots come back green.

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the cleanup, this was on my list! This should allow dropping the GCE runners on Linux altogether, right? Might be worth recording that benefit in the commit message.

libcxx/utils/ci/buildkite-pipeline.yml Show resolved Hide resolved
@EricWF
Copy link
Member Author

EricWF commented Nov 29, 2023

hanks a lot for the cleanup, this was on my list! This should allow dropping the GCE runners on Linux altogether, right? Might be worth recording that benefit in the commit message.

Sounds good. I'm working on moving the android builders too, and I'll be happy to help you move the mac builders too.
It should be pretty simple.

@EricWF
Copy link
Member Author

EricWF commented Nov 29, 2023

Submitting before the bots come back so I can stop wasting resources.

@ldionne ldionne changed the title remove linux buildkite builders entirely [libc++] Remove linux Buildkite builders entirely Nov 29, 2023
Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EricWF EricWF merged commit 9ac64ab into llvm:main Nov 29, 2023
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github:workflow libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants