Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][NFC] Fix missing dep in bazel #73854

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

michaelrj-google
Copy link
Contributor

Patch #73469 added a dependency from __support/bit.h to
__support/CPP/type_traits.h, but didn't add a dependency in the bazel.
This caused downstream build failures. This patch fixes the missing
dependency.

Patch llvm#73469 added a dependency from __support/bit.h to
__support/CPP/type_traits.h, but didn't add a dependency in the bazel.
This caused downstream build failures. This patch fixes the missing
dependency.
@llvmbot llvmbot added the libc label Nov 29, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Nov 29, 2023

@llvm/pr-subscribers-libc

Author: None (michaelrj-google)

Changes

Patch #73469 added a dependency from __support/bit.h to
__support/CPP/type_traits.h, but didn't add a dependency in the bazel.
This caused downstream build failures. This patch fixes the missing
dependency.


Full diff: https://github.com/llvm/llvm-project/pull/73854.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/BUILD.bazel (+1)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index ffb2652ed1419d0..860efbca1768853 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -594,6 +594,7 @@ libc_support_library(
     name = "__support_bit",
     hdrs = ["src/__support/bit.h"],
     deps = [
+        ":__support_cpp_type_traits",
         ":__support_macros_attributes",
     ],
 )

@cjdb
Copy link
Contributor

cjdb commented Nov 29, 2023

LGTM, thanks!

@michaelrj-google michaelrj-google merged commit 73f8aa0 into llvm:main Nov 29, 2023
3 of 4 checks passed
@michaelrj-google michaelrj-google deleted the libcBazelDepFix branch November 29, 2023 21:21
@gchatelet
Copy link
Contributor

Patch #73469 added a dependency from __support/bit.h to __support/CPP/type_traits.h, but didn't add a dependency in the bazel. This caused downstream build failures. This patch fixes the missing dependency.

Thx for the fix @michaelrj-google! Unfortunately, layering-check upstream is weaker than the internal one so we can't easily detect these breakage. I usually try to also test the patch internally but it's more work and I didn't do it this time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants