[libc] fix getchar_unlocked #73874
Merged
[libc] fix getchar_unlocked #73874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typo was leading to getc_unlocked.cpp.o being included into libc.a twice. I only noticed because I was trying to convert libc.a to a shared object via $ ld.lld -o libc.so --whole-archive libc.a which errored since getc_unlocked was being defined twice.
|
@llvm/pr-subscribers-libc Author: Nick Desaulniers (nickdesaulniers) ChangesA typo was leading to getc_unlocked.cpp.o being included into libc.a twice. I only noticed because I was trying to convert libc.a to a shared object via $ ld.lld -o libc.so --whole-archive libc.a which errored since getc_unlocked was being defined twice. Full diff: https://github.com/llvm/llvm-project/pull/73874.diff 1 Files Affected:
diff --git a/libc/src/stdio/generic/CMakeLists.txt b/libc/src/stdio/generic/CMakeLists.txt
index 2ecef879eb4bbfe..67fd1337c90a134 100644
--- a/libc/src/stdio/generic/CMakeLists.txt
+++ b/libc/src/stdio/generic/CMakeLists.txt
@@ -319,7 +319,7 @@ add_entrypoint_object(
add_entrypoint_object(
getchar_unlocked
SRCS
- getc_unlocked.cpp
+ getchar_unlocked.cpp
HDRS
../getc_unlocked.h
DEPENDS
|
nickdesaulniers
requested review from
gchatelet,
jhuber6,
lntue,
michaelrj-google and
legrosbuffle
jhuber6
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A typo was leading to getc_unlocked.cpp.o being included into libc.a twice.
I only noticed because I was trying to convert libc.a to a shared object via
$ ld.lld -o libc.so --whole-archive libc.a
which errored since getc_unlocked was being defined twice.