[TextAPI] Introduce Records & RecordSlice Types #74115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndyishida
commented
Dec 1, 2023
cyndyishida
commented
Dec 1, 2023
cyndyishida
force-pushed
the
eng/PR-tapi-api-records
branch
2 times, most recently
from
1aad4f5
to
919a120
Compare
ributzka
requested changes
Dec 1, 2023
ributzka
approved these changes
Dec 1, 2023
| StringRef ParentUmbrella; | ||
| StringRef InstallName; | ||
| StringRef UUID; | ||
| StringRef Path; | ||
| FileType fileType = FileType::Invalid; | ||
| llvm::MachO::PackedVersion CurrentVersion; | ||
| llvm::MachO::PackedVersion CompatVersion; | ||
| uint8_t SwiftABI = 0; |
There was a problem hiding this comment.
I think so, the linker continues to check it. I imagine since abi stability the value is always 7 though. We chatted about this a while back with @cooperp, but the details are slipping my mind.
There was a problem hiding this comment.
Oh yeah, the linker still enforces that the Swift ABI matches in all object files. Thats logic we needed back when changing the ABI happened each release. Its still there, but just never finds a mismatch.
If the Swift team did ever need to bump this version then the linker will be there to complain if it goes wrong :)
There was a problem hiding this comment.
Is the check/requirement just object files or also dylibs that link into the final linked image?
There was a problem hiding this comment.
Looks like dylibs too yeah. ld64 gets the swift version from used dylibs, tbds and object files, and makes sure they all match
`Record`'s hold target triple specific information about APIs and symbols. This holds information about the relationship between ObjC symbols and their linkage properties. It will be used to compare and run significant operations between the frontend representation of symbols in AST and symbol information extracted from Mach-O binaries. This differs from the lighter weight Symbol and SymbolSet class where they are deduplicated across targets and only represent exported symbols, that class is mostly used for serializing.
cyndyishida
force-pushed
the
eng/PR-tapi-api-records
branch
from
2b3a922
to
f52ba85
Compare
tschuett
reviewed
Dec 2, 2023
cyndyishida
added a commit
to cyndyishida/llvm-project
that referenced
this pull request
Jan 4, 2024
`Record`'s hold target triple specific information about APIs and symbols. This holds information about the relationship between ObjC symbols and their linkage properties. It will be used to compare and run significant operations between the frontend representation of symbols in AST and symbol information extracted from Mach-O binaries. This differs from the lighter weight Symbol and SymbolSet class where they are deduplicated across targets and only represent exported symbols, that class is mostly used for serializing. (cherry picked from commit b04b897)
cyndyishida
added a commit
to apple/llvm-project
that referenced
this pull request
Jan 5, 2024
`Record`'s hold target triple specific information about APIs and symbols. This holds information about the relationship between ObjC symbols and their linkage properties. It will be used to compare and run significant operations between the frontend representation of symbols in AST and symbol information extracted from Mach-O binaries. This differs from the lighter weight Symbol and SymbolSet class where they are deduplicated across targets and only represent exported symbols, that class is mostly used for serializing. (cherry picked from commit b04b897)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record's hold target triple specific information about APIs and symbols. This holds information about the relationship between ObjC symbols and their linkage properties. It will be used to compare and run significant operations between the frontend representation of symbols in AST and symbol information extracted from Mach-O binaries. This differs from the lighter weight Symbol and SymbolSet class where they are deduplicated across targets and only represent exported symbols, that class is mostly used for serializing.