[llvm] Adjust Autoupdater's llvm prefix detection

[urnathan]

Use consume_front to swallow the 'llvm.' prefix, and 'empty' to check there's at least one character left. It does not seem worth while checking for at least 2 characters left -- any well formed IR will have several characters remaining anyway.

probably the simplest of my autoupdater changes.

[nikic]

LGTM

[llvmbot]

@llvm/pr-subscribers-llvm-ir

Author: Nathan Sidwell (urnathan)

Changes

Use consume_front to swallow the 'llvm.' prefix, and 'empty' to check there's at least one character left. It does not seem worth while checking for at least 2 characters left -- any well formed IR will have several characters remaining anyway.

probably the simplest of my autoupdater changes.

---

Full diff: https://github.com/llvm/llvm-project/pull/74142.diff

1 Files Affected:

• (modified) llvm/lib/IR/AutoUpgrade.cpp (+3-3)

diff --git a/llvm/lib/IR/AutoUpgrade.cpp b/llvm/lib/IR/AutoUpgrade.cpp
index 9d546d3a5e9b1..7a40f24661caf 100644
--- a/llvm/lib/IR/AutoUpgrade.cpp
+++ b/llvm/lib/IR/AutoUpgrade.cpp
@@ -704,11 +704,11 @@ static Intrinsic::ID ShouldUpgradeNVPTXBF16Intrinsic(StringRef Name) {
 static bool UpgradeIntrinsicFunction1(Function *F, Function *&NewFn) {
   assert(F && "Illegal to upgrade a non-existent Function.");
 
-  // Quickly eliminate it, if it's not a candidate.
   StringRef Name = F->getName();
-  if (Name.size() <= 7 || !Name.starts_with("llvm."))
+
+  // Quickly eliminate it, if it's not a candidate.
+  if (!Name.consume_front("llvm.") || Name.empty())
     return false;
-  Name = Name.substr(5); // Strip off "llvm."
 
   switch (Name[0]) {
   default: break;