[clang][RISCVVEmitter] Remove no-op ptr-to-ptr bitcast (NFC) #74179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ptr-to-ptr bitcast which was added back in 939352b . With opaque pointers, the bitcast is now redundant. Opaque ptr cleanup effort.
llvmbot
added
clang
|
@llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-clang Author: Youngsuk Kim (JOE1994) ChangesRemove ptr-to-ptr bitcast which was added back in 939352b . With opaque pointers, the bitcast is now redundant. Opaque ptr cleanup effort. Full diff: https://github.com/llvm/llvm-project/pull/74179.diff 1 Files Affected:
diff --git a/clang/utils/TableGen/RISCVVEmitter.cpp b/clang/utils/TableGen/RISCVVEmitter.cpp
index cf731e8414a3b83..1fb41805a0473dd 100644
--- a/clang/utils/TableGen/RISCVVEmitter.cpp
+++ b/clang/utils/TableGen/RISCVVEmitter.cpp
@@ -180,13 +180,10 @@ void emitCodeGenSwitchBody(const RVVIntrinsic *RVVI, raw_ostream &OS) {
return;
}
- // Cast pointer operand of vector load intrinsic.
for (const auto &I : enumerate(RVVI->getInputTypes())) {
if (I.value()->isPointer()) {
assert(RVVI->getIntrinsicTypes().front() == -1 &&
"RVVI should be vector load intrinsic.");
- OS << " Ops[" << I.index() << "] = Builder.CreateBitCast(Ops[";
- OS << I.index() << "], ResultType->getPointerTo());\n";
}
}
|
wangpc-pp
reviewed
Dec 4, 2023
| @@ -180,13 +180,10 @@ void emitCodeGenSwitchBody(const RVVIntrinsic *RVVI, raw_ostream &OS) { | |||
| return; | |||
| } | |||
|
|
|||
| // Cast pointer operand of vector load intrinsic. | |||
| for (const auto &I : enumerate(RVVI->getInputTypes())) { | |||
There was a problem hiding this comment.
Why not remove this for totally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ptr-to-ptr bitcast which was added back in 939352b . With opaque pointers, the bitcast is now redundant.
Opaque ptr cleanup effort.