Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDB] Remove llvm/DebugInfo/PDB/Native/Formatters.h #74257

Merged

Conversation

kazutakahirata
Copy link
Contributor

The last use was removed by:

commit 7b84b67
Author: Zachary Turner zturner@google.com
Date: Mon Mar 26 18:01:07 2018 +0000

The last use was removed by:

  commit 7b84b67
  Author: Zachary Turner <zturner@google.com>
  Date:   Mon Mar 26 18:01:07 2018 +0000
@llvmbot
Copy link
Collaborator

llvmbot commented Dec 3, 2023

@llvm/pr-subscribers-debuginfo

Author: Kazu Hirata (kazutakahirata)

Changes

The last use was removed by:

commit 7b84b67
Author: Zachary Turner <zturner@google.com>
Date: Mon Mar 26 18:01:07 2018 +0000


Full diff: https://github.com/llvm/llvm-project/pull/74257.diff

1 Files Affected:

  • (removed) llvm/include/llvm/DebugInfo/PDB/Native/Formatters.h (-44)
diff --git a/llvm/include/llvm/DebugInfo/PDB/Native/Formatters.h b/llvm/include/llvm/DebugInfo/PDB/Native/Formatters.h
deleted file mode 100644
index 29c957eeb5e04..0000000000000
--- a/llvm/include/llvm/DebugInfo/PDB/Native/Formatters.h
+++ /dev/null
@@ -1,44 +0,0 @@
-//===- Formatters.h ---------------------------------------------*- C++ -*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef LLVM_DEBUGINFO_PDB_NATIVE_FORMATTERS_H
-#define LLVM_DEBUGINFO_PDB_NATIVE_FORMATTERS_H
-
-#include "llvm/ADT/ArrayRef.h"
-#include "llvm/ADT/StringRef.h"
-#include "llvm/DebugInfo/CodeView/Formatters.h"
-#include "llvm/DebugInfo/PDB/Native/RawConstants.h"
-#include "llvm/DebugInfo/PDB/Native/RawTypes.h"
-#include "llvm/Support/FormatProviders.h"
-
-#define FORMAT_CASE(Value, Name)                                               \
-  case Value:                                                                  \
-    Stream << Name;                                                            \
-    break;
-
-namespace llvm {
-template <> struct format_provider<pdb::PdbRaw_ImplVer> {
-  static void format(const pdb::PdbRaw_ImplVer &V, llvm::raw_ostream &Stream,
-                     StringRef Style) {
-    switch (V) {
-      FORMAT_CASE(pdb::PdbRaw_ImplVer::PdbImplVC110, "VC110")
-      FORMAT_CASE(pdb::PdbRaw_ImplVer::PdbImplVC140, "VC140")
-      FORMAT_CASE(pdb::PdbRaw_ImplVer::PdbImplVC2, "VC2")
-      FORMAT_CASE(pdb::PdbRaw_ImplVer::PdbImplVC4, "VC4")
-      FORMAT_CASE(pdb::PdbRaw_ImplVer::PdbImplVC41, "VC41")
-      FORMAT_CASE(pdb::PdbRaw_ImplVer::PdbImplVC50, "VC50")
-      FORMAT_CASE(pdb::PdbRaw_ImplVer::PdbImplVC70, "VC70")
-      FORMAT_CASE(pdb::PdbRaw_ImplVer::PdbImplVC70Dep, "VC70Dep")
-      FORMAT_CASE(pdb::PdbRaw_ImplVer::PdbImplVC80, "VC80")
-      FORMAT_CASE(pdb::PdbRaw_ImplVer::PdbImplVC98, "VC98")
-    }
-  }
-};
-}
-
-#endif

Copy link
Member

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to remove, thanks!

@kazutakahirata kazutakahirata merged commit f4b1f44 into llvm:main Dec 4, 2023
4 checks passed
@kazutakahirata kazutakahirata deleted the gh_cleanup_remove_Formatters branch December 4, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants