Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Support] Remove llvm/Support/Host.h #74261

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

kazutakahirata
Copy link
Contributor

The header file has been deprecated since:

commit f09cf34
Author: Archibald Elliott archibald.elliott@arm.com
Date: Tue Dec 20 10:24:02 2022 +0000

The header file has been deprecated since:

  commit f09cf34
  Author: Archibald Elliott <archibald.elliott@arm.com>
  Date:   Tue Dec 20 10:24:02 2022 +0000
@llvmbot
Copy link
Collaborator

llvmbot commented Dec 3, 2023

@llvm/pr-subscribers-llvm-support

Author: Kazu Hirata (kazutakahirata)

Changes

The header file has been deprecated since:

commit f09cf34
Author: Archibald Elliott <archibald.elliott@arm.com>
Date: Tue Dec 20 10:24:02 2022 +0000


Full diff: https://github.com/llvm/llvm-project/pull/74261.diff

3 Files Affected:

  • (removed) llvm/include/llvm/Support/Host.h (-18)
  • (modified) llvm/include/module.modulemap (-3)
  • (modified) polly/lib/External/isl/interface/extract_interface.cc (+1-1)
diff --git a/llvm/include/llvm/Support/Host.h b/llvm/include/llvm/Support/Host.h
deleted file mode 100644
index 113a252a12de9..0000000000000
--- a/llvm/include/llvm/Support/Host.h
+++ /dev/null
@@ -1,18 +0,0 @@
-//===-- llvm/Support/Host.h -------------------------------------*- C++ -*-===//
-//
-// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-// See https://llvm.org/LICENSE.txt for license information.
-// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-//
-//===----------------------------------------------------------------------===//
-///
-/// \file
-/// This header is deprecated in favour of `llvm/TargetParser/Host.h`.
-///
-//===----------------------------------------------------------------------===//
-
-#ifdef __GNUC__
-#pragma GCC warning                                                            \
-    "This header is deprecated, please use llvm/TargetParser/Host.h"
-#endif
-#include "llvm/TargetParser/Host.h"
diff --git a/llvm/include/module.modulemap b/llvm/include/module.modulemap
index 4c2ba437edb9f..8930fa8c087cf 100644
--- a/llvm/include/module.modulemap
+++ b/llvm/include/module.modulemap
@@ -380,9 +380,6 @@ module LLVM_Utils {
     umbrella "llvm/Support"
     module * { export * }
 
-    // Exclude this; deprecated.
-    exclude header "llvm/Support/Host.h"
-
     // Exclude this; it should only be used on Windows.
     exclude header "llvm/Support/Windows/WindowsSupport.h"
 
diff --git a/polly/lib/External/isl/interface/extract_interface.cc b/polly/lib/External/isl/interface/extract_interface.cc
index b94847c59035e..9bd20b0c72c6c 100644
--- a/polly/lib/External/isl/interface/extract_interface.cc
+++ b/polly/lib/External/isl/interface/extract_interface.cc
@@ -47,8 +47,8 @@
 #endif
 #include <llvm/Support/raw_ostream.h>
 #include <llvm/Support/CommandLine.h>
-#include <llvm/Support/Host.h>
 #include <llvm/Support/ManagedStatic.h>
+#include <llvm/TargetParser/Host.h>
 #include <clang/AST/ASTContext.h>
 #include <clang/AST/ASTConsumer.h>
 #include <clang/Basic/Builtins.h>

@lenary
Copy link
Member

lenary commented Dec 4, 2023

This didn't happen before because it is used by vendored isl code in Polly, as this diff shows. I'm not sure the status of updating that code, but the (external) author was informed a while ago about needing to update. I don't know who maintains Polly and whether they accept direct changes to vendored code or whether changes have to go upstream first.

@lenary
Copy link
Member

lenary commented Dec 4, 2023

@kazutakahirata
Copy link
Contributor Author

The changes have been made upstream to isl: https://repo.or.cz/isl.git/commitdiff/7ffab9c411283f3e22d39940dd8f57e9ccf497cb?hp=5d5b77e2369434a95d2d66824409b46d2155ba5b

Thanks! According to git log -- polly, it looks like various people have been making search-n-replace-type changes to polly in our repository.

@kazutakahirata kazutakahirata merged commit e1e34cc into llvm:main Dec 4, 2023
4 checks passed
@kazutakahirata kazutakahirata deleted the gh_cleanup_remove_Host branch December 4, 2023 20:54
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Dec 13, 2023
Summary:
https://reviews.llvm.org/D137838 moved Host.h and some other files under TargetParser.
llvm/llvm-project#74261 Removed it from Support folder.

Pull Request resolved: #115652
Approved by: https://github.com/davidberard98
guilhermeleobas pushed a commit to guilhermeleobas/pytorch that referenced this pull request Dec 18, 2023
Summary:
https://reviews.llvm.org/D137838 moved Host.h and some other files under TargetParser.
llvm/llvm-project#74261 Removed it from Support folder.

Pull Request resolved: pytorch#115652
Approved by: https://github.com/davidberard98
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
Summary:
https://reviews.llvm.org/D137838 moved Host.h and some other files under TargetParser.
llvm/llvm-project#74261 Removed it from Support folder.

Pull Request resolved: pytorch#115652
Approved by: https://github.com/davidberard98
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
Summary:
https://reviews.llvm.org/D137838 moved Host.h and some other files under TargetParser.
llvm/llvm-project#74261 Removed it from Support folder.

Pull Request resolved: pytorch#115652
Approved by: https://github.com/davidberard98
ZhiweiYan-96 pushed a commit to ZhiweiYan-96/pytorch that referenced this pull request Dec 22, 2023
Summary:
https://reviews.llvm.org/D137838 moved Host.h and some other files under TargetParser.
llvm/llvm-project#74261 Removed it from Support folder.

Pull Request resolved: pytorch#115652
Approved by: https://github.com/davidberard98
abhikran-quic added a commit to abhikran-quic/tvm that referenced this pull request Jan 9, 2024
Due to LLVM PR llvm/llvm-project#74261, Host.h has been moved
to a new location in LLVM
tqchen pushed a commit to apache/tvm that referenced this pull request Jan 10, 2024
[LLVM] Update Host.h LLVM header path

Due to LLVM PR llvm/llvm-project#74261, Host.h has been moved
to a new location in LLVM
junrushao pushed a commit to mlc-ai/relax that referenced this pull request Jan 17, 2024
[LLVM] Update Host.h LLVM header path

Due to LLVM PR llvm/llvm-project#74261, Host.h has been moved
to a new location in LLVM
junrushao pushed a commit to mlc-ai/relax that referenced this pull request Jan 17, 2024
[LLVM] Update Host.h LLVM header path

Due to LLVM PR llvm/llvm-project#74261, Host.h has been moved
to a new location in LLVM
junrushao pushed a commit to mlc-ai/relax that referenced this pull request Jan 21, 2024
[LLVM] Update Host.h LLVM header path

Due to LLVM PR llvm/llvm-project#74261, Host.h has been moved
to a new location in LLVM
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request Apr 4, 2024
Summary:
https://reviews.llvm.org/D137838 moved Host.h and some other files under TargetParser.
llvm/llvm-project#74261 Removed it from Support folder.

Pull Request resolved: pytorch#115652
Approved by: https://github.com/davidberard98
dnikolaev-amd pushed a commit to ROCm/pytorch that referenced this pull request Apr 26, 2024
Summary:
https://reviews.llvm.org/D137838 moved Host.h and some other files under TargetParser.
llvm/llvm-project#74261 Removed it from Support folder.

Pull Request resolved: pytorch#115652
Approved by: https://github.com/davidberard98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants