Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test][llvm-objdump][AArch64] Add tests for ELF AUTH constants #74298

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

kovdan01
Copy link
Contributor

@kovdan01 kovdan01 commented Dec 4, 2023

This patch introduces llvm-objdump tests for new AARCH64_AUTH_RELR, AARCH64_AUTH_RELRSZ and AARCH64_AUTH_RELRENT dynamic tags.

Depends on #74874

@kovdan01
Copy link
Contributor Author

kovdan01 commented Dec 4, 2023

The buildkite is failing as expected since the patch depends on change from #72713 which is not included in this PR. Locally, the build and tests pass. I'll manually re-run buildkite when #72713 is merged.

@llvmbot
Copy link
Collaborator

llvmbot commented Dec 4, 2023

@llvm/pr-subscribers-llvm-binary-utilities

@llvm/pr-subscribers-backend-aarch64

Author: Daniil Kovalev (kovdan01)

Changes

This patch introduces llvm-objdump tests for new AARCH64_AUTH_RELR, AARCH64_AUTH_RELRSZ and AARCH64_AUTH_RELRENT dynamic tags.


Full diff: https://github.com/llvm/llvm-project/pull/74298.diff

1 Files Affected:

  • (modified) llvm/test/tools/llvm-objdump/ELF/dynamic-section-machine-specific.test (+9)
diff --git a/llvm/test/tools/llvm-objdump/ELF/dynamic-section-machine-specific.test b/llvm/test/tools/llvm-objdump/ELF/dynamic-section-machine-specific.test
index 20219dd4893b7..203c210eb46a3 100644
--- a/llvm/test/tools/llvm-objdump/ELF/dynamic-section-machine-specific.test
+++ b/llvm/test/tools/llvm-objdump/ELF/dynamic-section-machine-specific.test
@@ -268,6 +268,9 @@ ProgramHeaders:
 # AARCH64:      Dynamic Section:
 # AARCH64-NEXT:  AARCH64_BTI_PLT      0x0000000000000001
 # AARCH64-NEXT:  AARCH64_PAC_PLT      0x0000000000000002
+# AARCH64-NEXT:  AARCH64_AUTH_RELR    0x0000000000000003
+# AARCH64-NEXT:  AARCH64_AUTH_RELRSZ  0x0000000000000004
+# AARCH64-NEXT:  AARCH64_AUTH_RELRENT 0x0000000000000005
 
 --- !ELF
 FileHeader:
@@ -283,6 +286,12 @@ Sections:
         Value: 1
       - Tag:   DT_AARCH64_PAC_PLT
         Value: 2
+      - Tag:   DT_AARCH64_AUTH_RELR
+        Value: 3
+      - Tag:   DT_AARCH64_AUTH_RELRSZ
+        Value: 4
+      - Tag:   DT_AARCH64_AUTH_RELRENT
+        Value: 5
       - Tag:   DT_NULL
         Value: 0
 ProgramHeaders:

@MaskRay
Copy link
Member

MaskRay commented Dec 4, 2023

[NFC][llvm-objdump][AArch64][ELF][PAC] Add tests for ELF AUTH constants

I'd omit [ELF][PAC] since they don't convey extra value. I may change [NFC] to [test].

Copy link
Collaborator

@jh7370 jh7370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@kovdan01
Copy link
Contributor Author

kovdan01 commented Dec 6, 2023

[NFC][llvm-objdump][AArch64][ELF][PAC] Add tests for ELF AUTH constants

I'd omit [ELF][PAC] since they don't convey extra value. I may change [NFC] to [test].

Thanks, updated the commit message as suggested, force-pushed the new one.

@kovdan01 kovdan01 changed the title [NFC][llvm-objdump][AArch64][ELF][PAC] Add tests for ELF AUTH constants [test][llvm-objdump][AArch64] Add tests for ELF AUTH constants Dec 6, 2023
This patch introduces llvm-objdump tests for new `AARCH64_AUTH_RELR`,
`AARCH64_AUTH_RELRSZ` and `AARCH64_AUTH_RELRENT` dynamic tags.
@kovdan01
Copy link
Contributor Author

kovdan01 commented Dec 9, 2023

Rebased and force-pushed to trigger buildkite (builds were red previously since being dependent on #74874). @metaflow As far as I understood, there is currently no way to trigger pre-merge checks without updating the branch - please provide a way for that since updating the branch via rebase + force-push when the build fails due to unrelated reasons clutters review history. Thanks!

@kovdan01 kovdan01 merged commit f0c0116 into llvm:main Dec 9, 2023
4 checks passed
@MaskRay
Copy link
Member

MaskRay commented Dec 9, 2023

Rebased and force-pushed to trigger buildkite (builds were red previously since being dependent on #74874). @metaflow As far as I understood, there is currently no way to trigger pre-merge checks without updating the branch - please provide a way for that since updating the branch via rebase + force-push when the build fails due to unrelated reasons clutters review history. Thanks!

I think rebasing while keeping all the incremental changes as "Commits" in the tab does not seem to clutter review history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants