[clang][AMDGPU] Update amdgpu_waves_per_eu attr docs #74587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Pierre van Houtryve (Pierre-vh) ChangesFull diff: https://github.com/llvm/llvm-project/pull/74587.diff 1 Files Affected:
diff --git a/clang/include/clang/Basic/AttrDocs.td b/clang/include/clang/Basic/AttrDocs.td
index bbe4de94cbabe..88f7c65e6e847 100644
--- a/clang/include/clang/Basic/AttrDocs.td
+++ b/clang/include/clang/Basic/AttrDocs.td
@@ -2659,8 +2659,9 @@ An error will be given if:
- Specified values violate subtarget specifications;
- Specified values are not compatible with values provided through other
attributes;
- - The AMDGPU target backend is unable to create machine code that can meet the
- request.
+
+The AMDGPU target backend will emit a warning whenever it is unable to
+create machine code that meets the request.
}];
}
|
arsenm
reviewed
Dec 7, 2023
| - The AMDGPU target backend is unable to create machine code that can meet the | ||
| request. | ||
|
|
||
| The AMDGPU target backend will emit a warning whenever it is unable to |
There was a problem hiding this comment.
This looks indented differently, without the list - as the previous comment did
There was a problem hiding this comment.
Do you want me to format it like this instead to mimic the previous formatting?
A warning will be given if:
- ...
There was a problem hiding this comment.
Oh, I wasn't looking at the header bit here. I was also assuming this is using the sphinx formatting rules? I suppose it doesn't really matter
arsenm
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.