Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm][NVPTX] Inform that 'DYNAMIC_STACKALLOC' is unsupported #74684

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

JOE1994
Copy link
Member

@JOE1994 JOE1994 commented Dec 7, 2023

Catch unsupported path early up, and emit error with information.

Motivated by the following threads:

@JOE1994 JOE1994 requested a review from Artem-B December 7, 2023 00:52
Catch unsupported path early up, and emit error with information.

Motivated by the following threads:
* https://discourse.llvm.org/t/nvptx-problems-with-dynamic-alloca/70745
* llvm#64017
@JOE1994
Copy link
Member Author

JOE1994 commented Dec 7, 2023

CI build failed because of other previous offending commit to mlir.
Will rebase onto latest main.

@JOE1994 JOE1994 force-pushed the NVPTXISelLowering_Err_DYNAMIC_STAKALLOC branch from eee746c to f176341 Compare December 7, 2023 15:11
@JOE1994 JOE1994 requested a review from inclyc December 14, 2023 20:04
@JOE1994 JOE1994 merged commit f930497 into llvm:main Dec 15, 2023
4 checks passed
@JOE1994 JOE1994 deleted the NVPTXISelLowering_Err_DYNAMIC_STAKALLOC branch December 15, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants