[CodeGen] Add analyses to help for porting GC passes #74972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
paperchalice
force-pushed
the
NPM/CodeGen/gc
branch
from
b88258c
to
bdb2d91
Compare
paperchalice
force-pushed
the
NPM/CodeGen/gc
branch
2 times, most recently
from
35f739d
to
cb96d32
Compare
arsenm
reviewed
Dec 11, 2023
paperchalice
force-pushed
the
NPM/CodeGen/gc
branch
from
cb96d32
to
3315a7d
Compare
paperchalice
added a commit
that referenced
this pull request
Dec 12, 2023
This pass is broken and looks like no one uses it for the last 15+ years.
```c++
bool Printer::runOnFunction(Function &F) {
if (F.hasGC())
return false;
GCFunctionInfo *FD = &getAnalysis<GCModuleInfo>().getFunctionInfo(F);
```
```c++
GCFunctionInfo &GCModuleInfo::getFunctionInfo(const Function &F) {
assert(!F.isDeclaration() && "Can only get GCFunctionInfo for a definition!");
assert(F.hasGC()); // Equivalent to `assert(false);` when called by `Printer::runOnFunction`
```
See also #74972.
paperchalice
force-pushed
the
NPM/CodeGen/gc
branch
2 times, most recently
from
ded9ddf
to
1430575
Compare
paperchalice
changed the title
GCInfoPrinter to new pass manager
|
Just remove the |
- `CollectorMetadataAnalysis` provides `GCStrategyMap`. - `GCFunctionAnalysis` provides `GCFunctionInfo`. `GCStrategyMap` owns `GCStrategy` pointers and this pass is used by `AsmPrinter` to iterate all GC strategies. Most passes that require `GCModuleInfo` actually require the `GCFunctionInfo`, so add `GCFunctionAnalysis` for convenience.
paperchalice
force-pushed
the
NPM/CodeGen/gc
branch
from
1430575
to
04ed65a
Compare
boomanaiden154
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
LGTM. Please wait for @arsenm to approve before merging this.
arsenm
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectorMetadataAnalysisprovidesGCStrategyMap.GCFunctionAnalysisprovidesGCFunctionInfo.GCStrategyMapownsGCStrategypointers and thispass is used by
AsmPrinterto iterate all GC strategies.Most passes that require
GCModuleInfoactually require theGCFunctionInfo,so add
GCFunctionAnalysisfor convenience.