[TextAPI] Add DylibReader #75006
Merged
[TextAPI] Add DylibReader #75006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for reading binary Mach-o dynamic libraries. It uses libObject APIs for extracting information relavant to TAPI and tbd files. This includes but is not limited to load commands encode data like install names, current/compat versions and symbols.
tschuett
reviewed
Dec 10, 2023
tschuett
reviewed
Dec 11, 2023
ributzka
requested changes
Dec 11, 2023
| @@ -103,6 +103,10 @@ class GlobalRecord : public Record { | |||
|
|
|||
| bool isFunction() const { return GV == Kind::Function; } | |||
| bool isVariable() const { return GV == Kind::Variable; } | |||
| void setKind(const Kind &V) { | |||
There was a problem hiding this comment.
In this case I would prefer to pass the argument by value. It is only an uint8_t enum. There is no need to pass it by reference.
There was a problem hiding this comment.
While I agree, I also wanted to keep the const mostly to ensure that the passed value isn't modified, just assigned. But that puts us back to #75006 (comment)
cyndyishida
added a commit
to cyndyishida/llvm-project
that referenced
this pull request
Jan 4, 2024
Add support for reading binary Mach-o dynamic libraries. It uses libObject APIs for extracting information relavant to TAPI and tbd files. This includes but is not limited to load commands encode data like install names, current/compat versions and symbols. (cherry picked from commit 634fedd)
cyndyishida
added a commit
to cyndyishida/llvm-project
that referenced
this pull request
Jan 4, 2024
…ylibReader (llvm#75006)" This reverts commit aa217eb. This reverts commit 634fedd. This breaks buildbots by introducing cycle dependency between libObject and TextAPI and breaks gcc compiles on buildbots. (cherry picked from commit 1fef0fa)
cyndyishida
added a commit
to apple/llvm-project
that referenced
this pull request
Jan 5, 2024
Add support for reading binary Mach-o dynamic libraries. It uses libObject APIs for extracting information relavant to TAPI and tbd files. This includes but is not limited to load commands encode data like install names, current/compat versions and symbols. (cherry picked from commit 634fedd)
cyndyishida
added a commit
to apple/llvm-project
that referenced
this pull request
Jan 5, 2024
…ylibReader (llvm#75006)" This reverts commit aa217eb. This reverts commit 634fedd. This breaks buildbots by introducing cycle dependency between libObject and TextAPI and breaks gcc compiles on buildbots. (cherry picked from commit 1fef0fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for reading binary Mach-o dynamic libraries. It uses libObject APIs for extracting information relavant to TAPI and tbd files. This includes but is not limited to load commands encode data like install names, current/compat versions and symbols.