-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test][sanitizer] Allow fork_threaded test on Msan, Tsan, Ubsan #75260
Merged
vitalybuka
merged 13 commits into
main
from
users/vitalybuka/spr/testsanitizer-allow-fork_threaded-test-on-msan-tsan
Dec 13, 2023
Merged
[test][sanitizer] Allow fork_threaded test on Msan, Tsan, Ubsan #75260
vitalybuka
merged 13 commits into
main
from
users/vitalybuka/spr/testsanitizer-allow-fork_threaded-test-on-msan-tsan
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) ChangesThey already include workarounds. Full diff: https://github.com/llvm/llvm-project/pull/75260.diff 1 Files Affected:
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/fork_threaded.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/fork_threaded.cpp
index 2264c55816638..72a2f78a5a3e7 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/fork_threaded.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/fork_threaded.cpp
@@ -1,6 +1,6 @@
// RUN: %clangxx -O0 %s -o %t && %env_tool_opts=die_after_fork=0 %run %t
-// UNSUPPORTED: *
+// UNSUPPORTED: asan, lsan, hwasan
// Forking in multithread environment is unsupported. However we already have
// some workarounds, and will add more, so this is the test.
|
thurstond
approved these changes
Dec 13, 2023
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
vitalybuka
changed the base branch from
users/vitalybuka/spr/main.testsanitizer-allow-fork_threaded-test-on-msan-tsan
to
main
December 13, 2023 04:00
vitalybuka
changed the title
[test][sanitizer] Allow fork_threaded test on Msan, Tsan
[test][sanitizer] Allow fork_threaded test on Msan, Tsan, Ubsan
Dec 13, 2023
vitalybuka
deleted the
users/vitalybuka/spr/testsanitizer-allow-fork_threaded-test-on-msan-tsan
branch
December 13, 2023 04:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They already include workarounds.