-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[X86][MC] Pre-commit test for 74713 #75288
Conversation
@llvm/pr-subscribers-backend-x86 Author: None (XinWang10) ChangesFull diff: https://github.com/llvm/llvm-project/pull/75288.diff 1 Files Affected:
diff --git a/llvm/test/MC/Disassembler/X86/avx-512.txt b/llvm/test/MC/Disassembler/X86/avx-512.txt
index 7c6f9d79ebd9b..508923624f1ff 100644
--- a/llvm/test/MC/Disassembler/X86/avx-512.txt
+++ b/llvm/test/MC/Disassembler/X86/avx-512.txt
@@ -58,6 +58,9 @@
# CHECK: vmovq %xmm19, 1016(%rdx)
0x62 0xe1 0xfd 0x08 0x7e 0x5a 0x7f
+# CHECK: vcvttps2uqq 128(%ecx), %xmm1 {%k2}
+0x67 0x62 0xf1 0x7d 0x0a 0x78 0x49 0x10
+
#####################################################
# MASK INSTRUCTIONS #
#####################################################
|
@llvm/pr-subscribers-mc Author: None (XinWang10) ChangesFull diff: https://github.com/llvm/llvm-project/pull/75288.diff 1 Files Affected:
diff --git a/llvm/test/MC/Disassembler/X86/avx-512.txt b/llvm/test/MC/Disassembler/X86/avx-512.txt
index 7c6f9d79ebd9b..508923624f1ff 100644
--- a/llvm/test/MC/Disassembler/X86/avx-512.txt
+++ b/llvm/test/MC/Disassembler/X86/avx-512.txt
@@ -58,6 +58,9 @@
# CHECK: vmovq %xmm19, 1016(%rdx)
0x62 0xe1 0xfd 0x08 0x7e 0x5a 0x7f
+# CHECK: vcvttps2uqq 128(%ecx), %xmm1 {%k2}
+0x67 0x62 0xf1 0x7d 0x0a 0x78 0x49 0x10
+
#####################################################
# MASK INSTRUCTIONS #
#####################################################
|
@@ -58,6 +58,9 @@ | |||
# CHECK: vmovq %xmm19, 1016(%rdx) | |||
0x62 0xe1 0xfd 0x08 0x7e 0x5a 0x7f | |||
|
|||
# CHECK: vcvttps2uqq 128(%ecx), %xmm1 {%k2} | |||
0x67 0x62 0xf1 0x7d 0x0a 0x78 0x49 0x10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an existing decoding tests for vcvttps2uqq? Could we put it there? Also, better to add it in encoding test too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No existing decode test for it, and it has had encoding test for it in llvm/test/MC/X86/intel-syntax-x86-avx512dq_vl.s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added it in f2b3e7c
You can update it at llvm/test/MC/Disassembler/X86/avx512dq_vl.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a task to supplement tests for AVX512 ISA, see https://reviews.llvm.org/D40776
It would be great if you can add them systematically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for info. But sorry, I don't have free time recently, could we defer it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The comment is for @KanRobert since he is updating test cases.
1512f5c
to
03e5417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.