Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X86][MC] Pre-commit test for 74713 #75288

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

XinWang10
Copy link
Contributor

No description provided.

@llvmbot llvmbot added backend:X86 mc Machine (object) code labels Dec 13, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Dec 13, 2023

@llvm/pr-subscribers-backend-x86

Author: None (XinWang10)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/75288.diff

1 Files Affected:

  • (modified) llvm/test/MC/Disassembler/X86/avx-512.txt (+3)
diff --git a/llvm/test/MC/Disassembler/X86/avx-512.txt b/llvm/test/MC/Disassembler/X86/avx-512.txt
index 7c6f9d79ebd9b..508923624f1ff 100644
--- a/llvm/test/MC/Disassembler/X86/avx-512.txt
+++ b/llvm/test/MC/Disassembler/X86/avx-512.txt
@@ -58,6 +58,9 @@
 # CHECK: vmovq   %xmm19, 1016(%rdx)
 0x62 0xe1 0xfd 0x08 0x7e 0x5a 0x7f
 
+# CHECK: vcvttps2uqq    128(%ecx), %xmm1 {%k2}
+0x67 0x62 0xf1 0x7d 0x0a 0x78 0x49 0x10
+
 #####################################################
 #                MASK INSTRUCTIONS                  #
 #####################################################

@llvmbot
Copy link
Collaborator

llvmbot commented Dec 13, 2023

@llvm/pr-subscribers-mc

Author: None (XinWang10)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/75288.diff

1 Files Affected:

  • (modified) llvm/test/MC/Disassembler/X86/avx-512.txt (+3)
diff --git a/llvm/test/MC/Disassembler/X86/avx-512.txt b/llvm/test/MC/Disassembler/X86/avx-512.txt
index 7c6f9d79ebd9b..508923624f1ff 100644
--- a/llvm/test/MC/Disassembler/X86/avx-512.txt
+++ b/llvm/test/MC/Disassembler/X86/avx-512.txt
@@ -58,6 +58,9 @@
 # CHECK: vmovq   %xmm19, 1016(%rdx)
 0x62 0xe1 0xfd 0x08 0x7e 0x5a 0x7f
 
+# CHECK: vcvttps2uqq    128(%ecx), %xmm1 {%k2}
+0x67 0x62 0xf1 0x7d 0x0a 0x78 0x49 0x10
+
 #####################################################
 #                MASK INSTRUCTIONS                  #
 #####################################################

@@ -58,6 +58,9 @@
# CHECK: vmovq %xmm19, 1016(%rdx)
0x62 0xe1 0xfd 0x08 0x7e 0x5a 0x7f

# CHECK: vcvttps2uqq 128(%ecx), %xmm1 {%k2}
0x67 0x62 0xf1 0x7d 0x0a 0x78 0x49 0x10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an existing decoding tests for vcvttps2uqq? Could we put it there? Also, better to add it in encoding test too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No existing decode test for it, and it has had encoding test for it in llvm/test/MC/X86/intel-syntax-x86-avx512dq_vl.s.

Copy link
Contributor

@KanRobert KanRobert Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added it in f2b3e7c

You can update it at llvm/test/MC/Disassembler/X86/avx512dq_vl.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a task to supplement tests for AVX512 ISA, see https://reviews.llvm.org/D40776
It would be great if you can add them systematically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for info. But sorry, I don't have free time recently, could we defer it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The comment is for @KanRobert since he is updating test cases.

Copy link
Contributor

@KanRobert KanRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XinWang10 XinWang10 merged commit 490c3aa into llvm:main Dec 13, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:X86 mc Machine (object) code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants