Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][runtime] Fix spelling of INQUIRE result #75372

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

klausler
Copy link
Contributor

Embarrassingly, the runtime was returning UNKNONN rather than UNKNOWN for things like INQUIRE(..., FORMAT=).

Embarrassingly, the runtime was returning UNKNONN rather than UNKNOWN
for things like INQUIRE(..., FORMAT=).
@llvmbot llvmbot added flang:runtime flang Flang issues not falling into any other category labels Dec 13, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Dec 13, 2023

@llvm/pr-subscribers-flang-runtime

Author: Peter Klausler (klausler)

Changes

Embarrassingly, the runtime was returning UNKNONN rather than UNKNOWN for things like INQUIRE(..., FORMAT=).


Full diff: https://github.com/llvm/llvm-project/pull/75372.diff

1 Files Affected:

  • (modified) flang/runtime/io-stmt.cpp (+1-1)
diff --git a/flang/runtime/io-stmt.cpp b/flang/runtime/io-stmt.cpp
index dedf1f8364ad37..4072dbf2659449 100644
--- a/flang/runtime/io-stmt.cpp
+++ b/flang/runtime/io-stmt.cpp
@@ -1346,7 +1346,7 @@ bool InquireUnconnectedFileState::Inquire(
   case HashInquiryKeyword("SEQUENTIAL"):
   case HashInquiryKeyword("STREAM"):
   case HashInquiryKeyword("UNFORMATTED"):
-    str = "UNKNONN";
+    str = "UNKNOWN";
     break;
   case HashInquiryKeyword("READ"):
     str =

Copy link
Contributor

@clementval clementval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@klausler
Copy link
Contributor Author

LGTM!

If there was a world record for quickest fix and review, we may have just broken it.

@klausler klausler merged commit 1794b61 into llvm:main Dec 26, 2023
6 checks passed
@klausler klausler deleted the inquire13 branch December 26, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:runtime flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants