Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BPF] get external linkage for calling convetion functions #75439

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inclyc
Copy link
Member

@inclyc inclyc commented Dec 14, 2023

NFC.

For support calling conv in gisel, sharing code with BPFISelLowering.

NFC.

For support calling conv in gisel, sharing code with BPFISelLowering.
@eddyz87
Copy link
Contributor

eddyz87 commented Jan 31, 2024

Note for the reviewer:
the "Entry" switch for calling conversion declaration controls how tblgen would emit generated function prototypes, as a static function or as a function visible in llvm namespace. See CallingConvEmitter::run() in CallingConvEmitter.cpp.

The commit lgtm, it follows same pattern as other back-ends (e.g. ARM).
@inclyc, if you want to land this, should probably add yonghong-song as a reviewer.

@inclyc inclyc marked this pull request as draft February 8, 2024 11:59
@inclyc
Copy link
Member Author

inclyc commented Feb 8, 2024

mark this as a draft PR because gisel code is not ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants