[clang-scan-deps] Fix check for empty Compilation

[Yaraslaut]

Closes #64144

Instead of checking for nullptr we need to ensure that JobList is not empty to proceed

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Yaraslau (Yaraslaut)

Changes

Closes #64144

Instead of checking for nullptr we need to ensure that JobList is not empty to proceed

---

Full diff: https://github.com/llvm/llvm-project/pull/75545.diff

1 Files Affected:

• (modified) clang/tools/clang-scan-deps/ClangScanDeps.cpp (+1-1)

diff --git a/clang/tools/clang-scan-deps/ClangScanDeps.cpp b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
index 75aa4ae97c618c..7253856f1a07b4 100644
--- a/clang/tools/clang-scan-deps/ClangScanDeps.cpp
+++ b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
@@ -728,7 +728,7 @@ getCompilationDataBase(int argc, char **argv, std::string &ErrorMessage) {
                            *Diags);
   std::unique_ptr<driver::Compilation> C(
       TheDriver.BuildCompilation(CommandLine));
-  if (!C)
+  if (C->getJobs().empty())
     return nullptr;
 
   auto Cmd = C->getJobs().begin();

[Yaraslaut]

Ping

[ChuanqiXu9]

It will be better to have a test for this.

[ChuanqiXu9]

Suggested change

	if (C->getJobs().empty())
	if (!C || C->getJobs().empty())

[Yaraslaut]

Corrected

[jansvoboda11]

LGTM, thanks!

[Yaraslaut]

It will be better to have a test for this.

I added lit test

[ChuanqiXu9]

LGTM then.