Gcc 75 libomptarget type convert #75562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 14, 2023 04:09
Expected<std::unique_ptr<PluginAdaptorTy>>. Changes to be committed: modified: openmp/libomptarget/src/PluginManager.cpp
jhuber6
reviewed
Dec 15, 2023
| @@ -47,7 +47,9 @@ PluginAdaptorTy::create(const std::string &Name) { | |||
| new PluginAdaptorTy(Name, std::move(LibraryHandler))); | |||
| if (auto Err = PluginAdaptor->init()) | |||
| return Err; | |||
| return PluginAdaptor; | |||
There was a problem hiding this comment.
Does putting std::move here not work?
|
FYI: #75419 |
|
Since this has been done in #75419 with the change suggested by Joseph Huber, I am closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with gcc-7.5 we get the error:
nochange/openmp/libomptarget/src/PluginManager.cpp: In static member function 'static llvm::Expected<std::unique_ptr<PluginAdaptorTy> > PluginAdaptorTy::create(const string&)':To overcome this an std::move has been added to convert from
std::unique_ptr<PluginAdaptorTy> to Expected<std::unique_ptr<PluginAdaptorTy>>This problem does not occur in higher versions of the compiler like gcc-12.2