Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerPC] Add test after #75271 on PPC. NFC. #75616

Merged
merged 7 commits into from
Dec 25, 2023
Merged

[PowerPC] Add test after #75271 on PPC. NFC. #75616

merged 7 commits into from
Dec 25, 2023

Conversation

bzEq
Copy link
Collaborator

@bzEq bzEq commented Dec 15, 2023

Demonstrate IMPLICIT_DEF implicit-def ... can be generated after coalescing on PPC.

The case is reduced from failure in #75570. The failure is triggered after #75271 .

@bzEq bzEq self-assigned this Dec 15, 2023
@bzEq bzEq changed the title [PowerPC] Add test for #75271 on PPC. NFC. [PowerPC] Add test after #75271 on PPC. NFC. Dec 15, 2023
@@ -0,0 +1,9039 @@
# RUN: llc -mtriple=powerpc64le-unknown-linux-gnu -verify-coalescing -run-pass=register-coalescer \
# RUN: -o - %s | FileCheck %s
--- |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case is much too big. Can you try running it through llvm-reduce MIR handling? That will likely remove most of the cruft. Then you can delete the IR and registers sections, and run through -run-pass=none to do some additional cleanups

Copy link
Collaborator Author

@bzEq bzEq Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried llvm-reduce, still 5000+ lines of mir. I'll try to simplify LLVM IR manually(like reducing the dimension of the vector)...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arsenm , most of the 5000+ lines are virtregs, I've removed them.

@bzEq bzEq requested a review from arsenm December 18, 2023 07:39
---
name: _Z13testTransposeIfLj31ELj17EEvv
alignment: 16
exposesReturnsTwice: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can drop most of these fields (running with -simplify-mir -run-pass=none will also do that)

successors: %bb.2(0x80000000)
liveins: $x2

%5081:vssrc = IMPLICIT_DEF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-run-pass=none will compact these numbers

debugInstrRef: false
failsVerification: false
tracksDebugUserValues: false
registers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can drop the section too, the uses have the inline class specifiers

@bzEq bzEq requested a review from arsenm December 18, 2023 08:18
Copy link
Member

@nemanjai nemanjai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment on lines 10 to 11
- { id: 0, size: 128, alignment: 128, local-offset: -128 }
- { id: 1, size: 4096, alignment: 16, local-offset: -4224 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit (feel free to ignore): there don't seem to be any stack accesses here. Do we need these?

@bzEq bzEq merged commit 5cfc7b3 into llvm:main Dec 25, 2023
3 of 4 checks passed
@bzEq bzEq deleted the remat-test branch December 25, 2023 16:22
aeubanks added a commit that referenced this pull request Jan 3, 2024
This reverts commit 5cfc7b3.

This depends on 0e46b49 which is being reverted.
@aeubanks
Copy link
Contributor

aeubanks commented Jan 3, 2024

sorry, I had to revert this since in ece1359 since it depended on another commit reverted in c414612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants