[PowerPC] Let base implementation decide if MI is rematerizable by default #75772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzEq
requested review from
arsenm,
chenzheng1030,
nemanjai,
lei137 and
stefanp-ibm
arsenm
approved these changes
Dec 18, 2023
nemanjai
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
I believe that the thinking was that this would help catch an issue where we set the Remat flag on an instruction and forget to update this. But the requirement is too strong since this may be called with target independent instructions.
Perhaps we can get both by asserting that the instruction has a size of zero (or at least less than 4) in the default case.
In any case, this unblocks a bot/commit, so LGTM.
|
The premerge failure is on windows and is related to MLIR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If MI is not PPC specific instructions, let base implementation decide if MI is rematerizable.
This can fix failure in #75570 after #75271 .