Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler-rt]Mark test compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp as unsupported on Windows #75886

Closed
wants to merge 1 commit into from

Conversation

minglotus-6
Copy link
Contributor

The compiler-rt test fails on Windows due to mismatched names (https://lab.llvm.org/buildbot/#/builders/127/builds/59907/steps/8/logs/stdio)

  • Given there are name matchers on many lines, mark the test as unsupported on Windows 64-bit for now. Need to get a machine to fix all the names.

@llvmbot llvmbot added compiler-rt PGO Profile Guided Optimizations labels Dec 19, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Dec 19, 2023

@llvm/pr-subscribers-pgo

Author: Mingming Liu (minglotus-6)

Changes

The compiler-rt test fails on Windows due to mismatched names (https://lab.llvm.org/buildbot/#/builders/127/builds/59907/steps/8/logs/stdio)

  • Given there are name matchers on many lines, mark the test as unsupported on Windows 64-bit for now. Need to get a machine to fix all the names.

Full diff: https://github.com/llvm/llvm-project/pull/75886.diff

1 Files Affected:

  • (modified) compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp (+3-7)
diff --git a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
index 82ca1cd7d0a564..85b624c8dbed04 100644
--- a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
+++ b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
@@ -23,13 +23,9 @@
 //
 // XFAIL: system-darwin
 //
-// Mark 32-bit Windows as UNSUPPORTED for now as opposed to XFAIL. This test
-// should fail on many (but not all) 32-bit Windows systems and succeed on the
-// rest. The flexibility in triple string parsing makes it tricky to capture
-// both sets accurately. i[3-9]86 specifies arch as Triple::ArchType::x86, (win32|windows)
-// specifies OS as Triple::OS::Win32
-//
-// UNSUPPORTED: target={{i.86.*windows.*}}
+// FIXME: Fix mangled name matcher on Windows and re-enable test on 64-bit
+// windows.
+// UNSUPPORTED: windows
 
 // RUN: rm -rf %t && split-file %s %t && cd %t
 

@minglotus-6 minglotus-6 changed the title [compiler-rt]Mark test as unsupported before fixing all the mangled names on Windows [compiler-rt]Mark test as unsupported on Windows Dec 19, 2023
@minglotus-6 minglotus-6 changed the title [compiler-rt]Mark test as unsupported on Windows [compiler-rt]Mark test compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp as unsupported on Windows Dec 19, 2023
@minglotus-6
Copy link
Contributor Author

I'll close this one and pursue a revert instead (#75888)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler-rt PGO Profile Guided Optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants